From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#17446: 24.4.50; What is the situation around `called-interactively-p'? Date: Fri, 9 May 2014 07:28:13 -0700 (PDT) Message-ID: <819a6ab8-db8e-4176-a778-02218f08e7af@default> References: <87tx8z6sp2.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1399645776 7238 80.91.229.3 (9 May 2014 14:29:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 9 May 2014 14:29:36 +0000 (UTC) Cc: 17446@debbugs.gnu.org To: Stefan Monnier , Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 09 16:29:29 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wilnf-0003xJ-R9 for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 May 2014 16:29:23 +0200 Original-Received: from localhost ([::1]:52831 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wilnf-00054e-9G for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 May 2014 10:29:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WilnT-00054K-GG for bug-gnu-emacs@gnu.org; Fri, 09 May 2014 10:29:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WilnK-00071u-Pr for bug-gnu-emacs@gnu.org; Fri, 09 May 2014 10:29:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WilnK-00071k-MT for bug-gnu-emacs@gnu.org; Fri, 09 May 2014 10:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WilnK-000125-9C for bug-gnu-emacs@gnu.org; Fri, 09 May 2014 10:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 May 2014 14:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17446-submit@debbugs.gnu.org id=B17446.13996457063924 (code B ref 17446); Fri, 09 May 2014 14:29:02 +0000 Original-Received: (at 17446) by debbugs.gnu.org; 9 May 2014 14:28:26 +0000 Original-Received: from localhost ([127.0.0.1]:57040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wilmj-00011E-TU for submit@debbugs.gnu.org; Fri, 09 May 2014 10:28:26 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:49472) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wilmi-00010w-0q for 17446@debbugs.gnu.org; Fri, 09 May 2014 10:28:24 -0400 Original-Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s49ESHm9024292 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 9 May 2014 14:28:18 GMT Original-Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s49ESE9m012816 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 9 May 2014 14:28:17 GMT Original-Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s49ESEQO029836; Fri, 9 May 2014 14:28:14 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6691.5000 (x86)] X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:88822 Archived-At: > > So what to do actually to fix such issues ? >=20 > Use an additional argument (you can call it `interactive'), > provided by the `interactive' spec? >=20 > > Do you plan to make something better around the terrible > > `called-interactively-p' ? >=20 > We have that already: the extra arg, as suggested in C-h > f called-interactively-p. Sure, we already do that. But that doesn't help when you define a "command similar to `repeat-complex-command'", as Thierry says, and as I have done too. Such a command has little control over the definition of the command that it invokes. > > That's ok, but what to do when nothing else is possible ? >=20 > AFAIK something else is always possible and preferable. But I don't > know enough about your problem to know that it's indeed also the case in > your situation. I thought he described it pretty well. Write a command that is similar to `repeat-complex-command'. Now make it work-around Emacs bug #14136. You end up doing for your new command something like what Emacs does for `repeat-complex-command'. And AFAICT, that works only when the helper function (similar to vanilla Emacs function `repeat-complex-command--called-interactively-skip') is byte-compiled.