From: Dmitry Gutov <dgutov@yandex.ru>
To: Tobias Rittweiler <trittweiler@gmail.com>
Cc: 45135-done@debbugs.gnu.org
Subject: bug#45135: 28.0.50; [PATCH] Add option to print file names in *xref* buffer relative to project root
Date: Wed, 30 Dec 2020 14:05:24 +0200 [thread overview]
Message-ID: <8194ba8f-b700-9375-f2b6-0a96d501e621@yandex.ru> (raw)
In-Reply-To: <CANXFPyVMUO46aLj-KKS3Ey-vKZzWkK4L4P+CfwpgNjO8FcH5SQ@mail.gmail.com>
Version: 28.1
Hi Tobias,
On 27.12.2020 08:55, Tobias Rittweiler wrote:
> Thank you. I tested the patch and it works fine.
>
> Some comments on the patch itself:
>
> 1. 'xref--project-root' returns a project root if 'project-root' is fboundp.
> Otherwise it returns a *list* of roots.
>
> 2. And in the second case, 'xref-backend-references' conses that list
> of roots to the list of external roots. I.e. it constructs an
> improper list
> which it then passes to 'mapcan'. This is a bug, isn't it?
>
> 3. 'xref-expanded-seach-root` mispells "search"
Thanks for the comments, I fixed them now.
Also I've simplified the change closer to your original code. If
anything, that made satisfying the tests easier.
Pushed as 13b59c690a.
That code also doesn't consider the "external roots", I figured it would
be better to keep the group names unique.
But we can revisit that later, if you or others do find those external
long file names annoying (let me know). For now, closing.
next prev parent reply other threads:[~2020-12-30 12:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 15:08 bug#45135: 28.0.50; [PATCH] Add option to print file names in *xref* buffer relative to project root Tobias Rittweiler
2020-12-23 2:16 ` Dmitry Gutov
2020-12-26 2:21 ` Dmitry Gutov
2020-12-26 7:54 ` Eli Zaretskii
2020-12-27 6:55 ` Tobias Rittweiler
2020-12-30 12:05 ` Dmitry Gutov [this message]
2020-12-27 7:10 ` Tobias Rittweiler
2020-12-30 2:06 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8194ba8f-b700-9375-f2b6-0a96d501e621@yandex.ru \
--to=dgutov@yandex.ru \
--cc=45135-done@debbugs.gnu.org \
--cc=trittweiler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.