org-link-search: Augment signature?

org-link-search: Augment signature?

[Jambunathan K]

I have a small utility routine that depends on org-link-search to throw
an error. It knew how to create the missing headline on it's own.

A recent change and the default settings breaks the original behaviour.

Using this as pretext, may I suggest that signature of org-link-search
be changed from

(org-link-search S &optional TYPE AVOID-POS)

to

(org-link-search S &optional TYPE AVOID-POS NOERROR)

or an equivalent one.

ps: A cursory look suggests that the above change would also obviate the
need for dynamically binding org-link-search-inhibit-query.

Thanks,
Jambunathan K.

Re: org-link-search: Augment signature?

[Carsten Dominik]

On Aug 19, 2010, at 2:15 PM, Jambunathan K wrote:

>
> I have a small utility routine that depends on org-link-search to  
> throw
> an error. It knew how to create the missing headline on it's own.
>
> A recent change and the default settings breaks the original  
> behaviour.
>
> Using this as pretext, may I suggest that signature of org-link-search
> be changed from
>
> (org-link-search S &optional TYPE AVOID-POS)
>
> to
>
> (org-link-search S &optional TYPE AVOID-POS NOERROR)
>
> or an equivalent one.

I think a good solution for your utility would be to bind

(let ((org-link-search-must-match-exact-headline t))

around the body of the function.

>
> ps: A cursory look suggests that the above change would also obviate  
> the
> need for dynamically binding org-link-search-inhibit-query.

I am not sure if I understand this part.

- Carsten

Re: org-link-search: Augment signature?

[Jambunathan K]

    >> On a related note, how would I accomplish this - "Create the
    >> headline automagically everytime but suppress the prompt".
    >> 
    >> This is the code snippet as it is in git today -
    >> 
    >> ((and (not org-link-search-inhibit-query) (eq
    >> org-link-search-must-match-exact-headline 'query-to-create)
    >> (y-or-n-p "No match - create this as a new heading? "))
    >> (goto-char (point-max)) (or (bolp) (newline)) (insert "* " s
    >> "\n") (beginning-of-line 0))
    >> 
    >> 
    >> Shouldn't the above block should instead read thus
    >> 
    >> ((and (eq org-link-search-must-match-exact-headline
    >> 'query-to-create) (or org-link-search-inhibit-query (y-or-n-p "No
    >> match - create this as a new heading? ")) (goto-char (point-max))
    >> (or (bolp) (newline)) (insert "* " s "\n") (beginning-of-line 0))


    > Why???

    > The above code would stop at the first form that returns nil, for
    > example (insert ...) or even (newline)


Mistake on my part. (Not a native speaker of elisp here)

((and
  (eq org-link-search-must-match-exact-headline 'query-to-create)
  (or org-link-search-inhibit-query
      (y-or-n-p "No match - create this as a new heading? ")))
 (goto-char (point-max))
 (or (bolp) (newline))
 (insert "* " s "\n")
 (beginning-of-line 0))

My gut feeling is that there is some inconsistency in the way
org-link-search-must-match-exact-headline and
org-link-search-inhibit-query work together.

Jambunathan K.