all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'Stefan Monnier'" <monnier@iro.umontreal.ca>
Cc: 7291@debbugs.gnu.org
Subject: bug#7291: 24.0.50; `non-essential' is incomprehensible
Date: Fri, 29 Oct 2010 09:47:26 -0700	[thread overview]
Message-ID: <814E70A041AB4DC2A29E614DB19D2247@us.oracle.com> (raw)
In-Reply-To: <jwvlj5h2dhh.fsf-monnier+emacs@gnu.org>

> >  Code that might perform a non-essential task can test this
> >  variable and dispense with performing the task if the value
> >  is non-nil.
> 
> No, this is backwards: e.g. Tramp doesn't know that what it does is
> non-essential, 

Precisely why I said that the task to be performed _might_ be non-essential.

Tramp knows that its operation might be disruptive, and it knows that some other
code might not want that disruption, and that to communicate that the other code
might indicate that the interruption action is "non-essential" (in which case it
should be skipped).

This variable is about conditionally inhibiting certain actions that could
disrupt the user.  It would be better for it to be named something that reflects
that, but I'm not going to fight that battle.  (Consequently, I won't bother to
suggest a different name.  I'll just say that that is what this var is about -
it is not about "non-essential" anything.)

> which is why it needs to look up non-essential 
> to figure that out.

And that is why I said that Tramp can test the variable and skip the task if the
value indicates non-essential.

We are saying the same thing, or trying to.

> The only reason it does such a look up is not because it
> suspects this is non-essential, but because it is about to do 
> something that may disturb the user, so it first wants to make
> sure it is really necessary to do it.

We agree about you wrote in this paragraph (starting with "Tramp doesn't know").
That's just what I tried to say too.  So I suggest you put such info into the
doc string.  I have no objection to your wording here or similar.

Both parts of the story need to be presented clearly: (1) the code such as Tramp
that conditionally disturbs the user (depending on the var value) and (2) the
code such as Icomplete that binds the var during an operation that it does not
want interrupted.

HTH.






  reply	other threads:[~2010-10-29 16:47 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-27 22:30 bug#7291: 24.0.50; `non-essential' is incomprehensible Drew Adams
2010-10-28  0:52 ` Stefan Monnier
2010-10-28 16:22   ` Drew Adams
2010-10-28 17:14     ` Stefan Monnier
2010-10-28 18:43       ` Michael Albinus
2010-10-28 18:51       ` Drew Adams
2010-10-28 20:12         ` Stefan Monnier
2010-10-28 21:58           ` Drew Adams
2010-10-29 16:20             ` Stefan Monnier
2010-10-29 16:47               ` Drew Adams [this message]
2010-10-29 17:36                 ` Stefan Monnier
2010-10-29  8:36           ` Andreas Schwab
2010-10-29 16:03             ` Stefan Monnier
2010-10-29 16:21               ` Andreas Schwab
2010-10-29 18:29               ` Eli Zaretskii
2010-10-29 23:00                 ` Andy Moreton
2010-10-30  6:52                   ` Eli Zaretskii
2010-10-30 16:16                     ` Drew Adams
2010-10-30 17:53                       ` Michael Albinus
2010-10-30 20:05                         ` Drew Adams
2010-10-29 18:56           ` Alan Mackenzie
2010-10-28 17:33 ` James Cloos
2010-10-28 18:53   ` Drew Adams
2011-07-14 14:35   ` Lars Magne Ingebrigtsen
2010-10-31  2:34 ` MON KEY

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=814E70A041AB4DC2A29E614DB19D2247@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=7291@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.