From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [RFC] Using a display_info union instead of a typedef Display_Info Date: Tue, 16 Apr 2019 11:54:57 -0700 Organization: UCLA Computer Science Department Message-ID: <813c7912-e0fd-57aa-37c4-a1e1974e1434@cs.ucla.edu> References: <87mukvw4la.fsf@gmail.com> <87imvjw3uu.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="246188"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: emacs-devel@gnu.org To: Alex Gramiak Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 16 21:26:51 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hGTjG-0011vM-Da for ged-emacs-devel@m.gmane.org; Tue, 16 Apr 2019 21:26:50 +0200 Original-Received: from localhost ([127.0.0.1]:41622 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGTjF-00077Z-C0 for ged-emacs-devel@m.gmane.org; Tue, 16 Apr 2019 15:26:49 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGTEa-0006GT-Ug for emacs-devel@gnu.org; Tue, 16 Apr 2019 14:55:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGTEY-0006rO-Vr for emacs-devel@gnu.org; Tue, 16 Apr 2019 14:55:08 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:38574) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hGTEV-0006og-ID for emacs-devel@gnu.org; Tue, 16 Apr 2019 14:55:05 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 18C7F161764; Tue, 16 Apr 2019 11:55:00 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id SbudwncMtnvv; Tue, 16 Apr 2019 11:54:58 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 70541161766; Tue, 16 Apr 2019 11:54:58 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0CxEE6e7xaqQ; Tue, 16 Apr 2019 11:54:58 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 272F5161629; Tue, 16 Apr 2019 11:54:58 -0700 (PDT) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH In-Reply-To: <87imvjw3uu.fsf@gmail.com> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235547 Archived-At: Thanks, this looks like a step in the right direction. I have a few minor quibbles: function names like U_DISPLAY_INFO_X shouldn't be lowercase, and more important DISPLAY_INFO/display_info should be a function and not a macro, and it should return a pointer to new generic type, 'struct generic_display_info' say, that contains only the leading elements common to all the structures - and all the structures should be changed to have a first member of that generic type. See the first members of 'struct Lisp_Vector' and 'struct Lisp_Char_Table' for an example of this. I have my doubts about installing this in master now, as it doesn't have direct benefit now. Ironically, one of the patches I have in mind (which should improve overall Emacs performance significantly) involves reverting a patch installed some years ago that was intended to be a refactoring to do later work that was never done. So I appreciate Eli's concern about merging this into master right away. However, the patch seems to be a good candidate for installing into a scratch branch that later patches can improve on, and once that branch has direct benefits we could merge that into master.