Re: Assertion violation in pdumper.c

[Paul Eggert <eggert@cs.ucla.edu>]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

On 8/17/20 7:07 AM, Eli Zaretskii wrote:

> -  if (offset < dump_private.header.cold_start
> +  if (offset < dump_private.header.discardable_start

Yes, that's a good fix. Thanks for finding and fixing this bug. I installed the 
attached.

[-- Attachment #2: 0001-Fix-assertion-violation-in-pdumper.c.patch --]
[-- Type: text/x-patch, Size: 1063 bytes --]

From 3a17b9f265fd6d42e82f649533027b4531f9dabf Mon Sep 17 00:00:00 2001
From: Eli Zaretskii <eliz@gnu.org>
Date: Mon, 17 Aug 2020 09:30:02 -0700
Subject: [PATCH] Fix assertion violation in pdumper.c

* src/pdumper.c (pdumper_find_object_type_impl): When checking
last_mark_bits, require the offset to be less than
discardable_start, not cold_start.  This fixes a typo introduced in
2020-08-14T21:33:21Z!eggert@cs.ucla.edu (Bug#42832).
---
 src/pdumper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/pdumper.c b/src/pdumper.c
index 2d1b19283c..217ffa6783 100644
--- a/src/pdumper.c
+++ b/src/pdumper.c
@@ -4999,7 +4999,7 @@ pdumper_find_object_type_impl (const void *obj)
   if (offset % DUMP_ALIGNMENT != 0)
     return PDUMPER_NO_OBJECT;
   ptrdiff_t bitno = offset / DUMP_ALIGNMENT;
-  if (offset < dump_private.header.cold_start
+  if (offset < dump_private.header.discardable_start
       && !dump_bitset_bit_set_p (&dump_private.last_mark_bits, bitno))
     return PDUMPER_NO_OBJECT;
   const struct dump_reloc *reloc =
-- 
2.17.1