Re: `session-jump-to-last-change' and org-mode

[Nick Dokos <nicholas.dokos@hp.com>]

Le Wang <l26wang@gmail.com> wrote:

> On Thu, Mar 17, 2011 at 3:02 PM, Carsten Dominik <carsten.dominik@gmail.com> wrote:
> 
>     (defadvice session-jump-to-last-change (after org-expand activate compile)
>      "Reveal hidden point after jumping."
>      (when (and (eq major-mode 'org-mode)
>                 (outline-invisible-p))
>        (org-reveal)))
> 
> Thanks Carsten!  That's xactly what I wanted.  I'll coordinate with session's author to get this
> change integrated.
> 

Why would you need to coordinate with the session author about advising
a function? It's your own personal advice and you can do whatever you
want. Of course, as Carsten pointed out, there is good advice and there
is bad advice, and you should only give good advice. But you are not
requesting any changes to the session code. You just stick the advice in
your .emacs and that's that.

Am I missing something?
Nick