all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Sebastien Vauban" <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org>
To: help-gnu-emacs-mXXj517/zsQ@public.gmane.org
Subject: Re: flet is obsolete, but...
Date: Thu, 11 Oct 2012 16:55:22 +0200	[thread overview]
Message-ID: <80y5jdkqhx.fsf@somewhere.org> (raw)
In-Reply-To: barmar-210B15.10311810102012@news.eternal-september.org

Hello all,

Barry Margolin wrote:
> In article <804nm2zekk.fsf-oHC15RC7JGTNLxjTenLetw@public.gmane.org>,
>  "Sebastien Vauban" <wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw@public.gmane.org> wrote:
>
>> Hello,
>> 
>> `flet' is an obsolete macro (as of 24.3); use either `cl-flet' or `cl-letf'.
>> 
>> But doing so in the following code:
>> 
>> --8<---------------cut here---------------start------------->8---
>>   (defun my/revert-buffer ()
>>     "Unconditionally revert current buffer."
>>     (interactive)
>>     (flet ((yes-or-no-p (msg) t))
>>       (revert-buffer)))
>> --8<---------------cut here---------------end--------------->8---
>> 
>> does not lead to the right things:
>> 
>> - use cl-flet, and the code doesn't behave as it should (i.e., it does ask for
>>   a confirmation, before reverting)'
>
> cl-flet does lexical binding, not dynamic.
>
>> 
>> - use cl-letf, and you've got an error:
>>   cl-letf: `let' bindings can have only one value-form: yes-or-no-p, (msg), t
>> 
>> What should I do?
>
> Sounds like you didn't write your cl-letf correctly. Did you read its 
> documentation? It's not a drop-in replacement for flet, since it's more 
> general than this (it's used to temporarily assign to any place that can 
> be set with setf).
>
> (letf (((symbol-function 'yes-or-no-p)
>            #'(lambda (msg) t)))
>   (revert-buffer))

Thanks for your answers. It helped a lot, even if the above is still a bit
cryptic to me.

And, yes, I thought that the replacement was purely a syntaxical exchange of
words...

Best regards,
  Seb

-- 
Sebastien Vauban


  reply	other threads:[~2012-10-11 14:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-10 12:39 flet is obsolete, but Sebastien Vauban
2012-10-10 13:17 ` Jambunathan K
2012-10-10 13:18 ` Jambunathan K
2012-10-10 14:31 ` Barry Margolin
2012-10-11 14:55   ` Sebastien Vauban [this message]
     [not found] ` <mailman.10697.1349875031.855.help-gnu-emacs@gnu.org>
2012-10-11  8:04   ` Sebastien Vauban
2012-10-11  8:10     ` Tassilo Horn
2012-10-11  8:17     ` Jambunathan K
2012-10-11 13:48     ` Drew Adams
2012-10-11 14:33       ` Ludwig, Mark
2012-10-11 15:18         ` `f5' for refreshing/reverting without confirmation [was: flet is obsolete, but...] Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80y5jdkqhx.fsf@somewhere.org \
    --to=wxhgmqzgwmuf-genee64ty+gs+fvcfc7uqw@public.gmane.org \
    --cc=help-gnu-emacs-mXXj517/zsQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.