From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.bugs Subject: bug#55205: 28.1.50; completion--replace illegally mutates completion candidates Date: Sun, 1 May 2022 20:06:52 +0200 Message-ID: <80d87c54-8964-8440-8327-e0e0ae9c56f2@daniel-mendler.de> References: <4d1b8687-20f2-137a-2739-7bba28828991@daniel-mendler.de> <87wnf5mpt4.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4100"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55205@debbugs.gnu.org To: Stefan Monnier , Lars Ingebrigtsen , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 01 20:08:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nlDzQ-0000ui-SX for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 May 2022 20:08:12 +0200 Original-Received: from localhost ([::1]:38232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nlDzP-0008G6-El for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 May 2022 14:08:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nlDzG-0008Cn-SB for bug-gnu-emacs@gnu.org; Sun, 01 May 2022 14:08:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40248) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nlDzG-00089S-Ih for bug-gnu-emacs@gnu.org; Sun, 01 May 2022 14:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nlDzG-0003Am-BU for bug-gnu-emacs@gnu.org; Sun, 01 May 2022 14:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 May 2022 18:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55205 X-GNU-PR-Package: emacs Original-Received: via spool by 55205-submit@debbugs.gnu.org id=B55205.165142842312122 (code B ref 55205); Sun, 01 May 2022 18:08:02 +0000 Original-Received: (at 55205) by debbugs.gnu.org; 1 May 2022 18:07:03 +0000 Original-Received: from localhost ([127.0.0.1]:34145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlDyJ-00039S-JO for submit@debbugs.gnu.org; Sun, 01 May 2022 14:07:03 -0400 Original-Received: from server.qxqx.de ([178.63.65.180]:41897 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlDyH-00038x-MP for 55205@debbugs.gnu.org; Sun, 01 May 2022 14:07:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kjnncOa27K5VjWdhzCFdxEqx8YfvEj4spfpbMCIT10g=; b=hEMQpjJlZYyBsW/xFgZFOvtepd srFUPu+lFnvETQnsBID0Y73kakS2ulZV5DMNKfp5eNrrJbcX2flhiLbRK93IEBvaNhMrE3Jc1m00k MSmhYhz5cJgj41x84E5kHG0v81X6KEa7VLYNL9vy3UM1f6eSqW8U9ygOIyE7oL++FPJA=; Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231185 Archived-At: > I think it's much better to fix the bug, so I just pushed the patch > below to `master`. > > I think it's safe enough for `emacs-28`, but I can't claim it's > "obviously safe", the way I could about that same `copy-sequence` in > `cl-generic.el`. > > diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el > index ef71b4e6be6..fb473cf71b0 100644 > --- a/lisp/minibuffer.el > +++ b/lisp/minibuffer.el > @@ -1140,6 +1140,7 @@ completion--replace > ;; The properties on `newtext' include things like the > ;; `completions-first-difference' face, which we don't want to > ;; include upon insertion. > + (setq newtext (copy-sequence newtext)) ;Don't modify the arg by side-effect. > (if minibuffer-allow-text-properties > ;; If we're preserving properties, then just remove the faces > ;; and other properties added by the completion machinery. Thanks, Stefan! This is the proper fix. I also think this is safe enough for the emacs-28 branch. It will also fix the icomplete bug there, where minibuffer-force-complete *incorrectly* strips the text properties. Daniel