From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#6695: bug#8439: [PATCH] ffap.el -- detect paths with spaces (v4) Date: Sat, 15 Aug 2020 12:33:48 -0700 (PDT) Message-ID: <80adac77-abed-48dd-81df-653100abcdd0@default> References: <<87pqoyaxu0.fsf@blue.sea.net>> <<87zk3i7tbu.fsf@picasso.cante.net>> <> <<20121020075601.GD29154@picasso.cante.net>> <<20121020084551.GE29154@picasso.cante.net>> <<87mucmn2gs.fsf@gnus.org>> <<87tux574te.fsf@gnus.org>> <<83v9hkjmzb.fsf@gnu.org>> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10400"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 8439@debbugs.gnu.org, 6695@debbugs.gnu.org, jari.aalto@cante.net To: Eli Zaretskii , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 15 21:35:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k71xP-0002a9-Dm for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Aug 2020 21:35:11 +0200 Original-Received: from localhost ([::1]:40922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k71xO-0002Nd-Fi for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Aug 2020 15:35:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k71xG-0002NQ-8i for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2020 15:35:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44935) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k71xF-0000C1-Uy for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2020 15:35:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k71xF-0000lu-RE for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2020 15:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Aug 2020 19:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6695 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 6695-submit@debbugs.gnu.org id=B6695.15975200462896 (code B ref 6695); Sat, 15 Aug 2020 19:35:01 +0000 Original-Received: (at 6695) by debbugs.gnu.org; 15 Aug 2020 19:34:06 +0000 Original-Received: from localhost ([127.0.0.1]:56481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k71wM-0000kZ-J0 for submit@debbugs.gnu.org; Sat, 15 Aug 2020 15:34:06 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:38322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k71wJ-0000jw-Ei; Sat, 15 Aug 2020 15:34:05 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07FJXbiV005121; Sat, 15 Aug 2020 19:33:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=sCIfUF2CmXIwIJ++7msCsZEbclCKOcFIUajXC0sG95Q=; b=pY1bWYAMBDmFZ/F0TeBPPEYlKjlfvehH8hYUVwJsQN3zro8vHHyWFRXeBsRPqN7wZ7Yc gmJkVdex8YFZr/C3kZyrZVLmc3ffRENWSJH8we6OX+RomiAzcAUtMHdm4lC5u9tlrtLU dFaEaGjrww+Jgd5o80f5uBIhlFBOFxmLJWK8fhWX4LLijg+dLI5lRwokn6oLWr64BfAp mCgEG8/GgYvqhZtoIHhclasjK0cVJQ3r+uxxDEu8hWc2MWP500biqYnWQ889yGIXVAXe HKG3zkVX8YqhVFNnLGdMtI7Mn68hCNPHrbJOpaFYDbEEKzoNyX6+i9EWpCY4/80FX34L ZA== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 32x7nm1h2q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 15 Aug 2020 19:33:51 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07FJReZm105891; Sat, 15 Aug 2020 19:33:51 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 32x7h1ker2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 15 Aug 2020 19:33:51 +0000 Original-Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 07FJXnEN003127; Sat, 15 Aug 2020 19:33:49 GMT In-Reply-To: <<83v9hkjmzb.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5017.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9714 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 suspectscore=0 mlxlogscore=999 malwarescore=0 adultscore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008150154 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9714 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 impostorscore=0 priorityscore=1501 adultscore=0 mlxscore=0 mlxlogscore=999 lowpriorityscore=0 bulkscore=0 phishscore=0 malwarescore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008150154 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185256 Archived-At: > > The c: isn't included, but is that to be expected? >=20 > Is it? I thought the intent was to include the full file name, which > means the drive letter should be included. Otherwise the file will > not be found. >=20 > > So what do people think? Good or bad? Does this work in any way > > sensibly for people? >=20 > Since the heuristic only covers some use cases, I think we should have > it off by default, and we should document its potential pitfalls in > the doc string. With those qualifications, I'm okay with adding this > optional feature. FWIW: As the submitter of the original bug report (#6695), I'd say this shouldn't be marked "fixed" if the drive letter part (e.g. c:/) isn't included on MS Windows. It sounds like it represents some progress, but it sounds like it's not fixed yet.