From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?iso-8859-1?Q?Vincent_Bela=EFche?= Newsgroups: gmane.emacs.devel Subject: RE: Patch to allow texi2any for EMACS manual compilation Date: Tue, 23 Sep 2014 22:54:06 +0200 Message-ID: <807g0ucb2p.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1411505998 14106 80.91.229.3 (23 Sep 2014 20:59:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Sep 2014 20:59:58 +0000 (UTC) Cc: =?iso-8859-1?Q?Vincent_Bela=EFche?= , pertusus@free.fr, EMACS devel list , Karl Berry To: Andreas Schwab , Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 23 22:59:52 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XWX6g-0005xW-86 for ged-emacs-devel@m.gmane.org; Tue, 23 Sep 2014 22:54:42 +0200 Original-Received: from localhost ([::1]:55877 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWX6f-0003OM-P8 for ged-emacs-devel@m.gmane.org; Tue, 23 Sep 2014 16:54:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWX6Z-0003O6-3t for emacs-devel@gnu.org; Tue, 23 Sep 2014 16:54:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWX6U-0001aL-Ow for emacs-devel@gnu.org; Tue, 23 Sep 2014 16:54:35 -0400 Original-Received: from smtp09.smtpout.orange.fr ([80.12.242.131]:19785 helo=smtp.smtpout.orange.fr) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWX6U-0001ZO-Fn for emacs-devel@gnu.org; Tue, 23 Sep 2014 16:54:30 -0400 Original-Received: from CHOUNEK ([90.32.172.128]) by mwinf5d17 with ME id ukuM1o0062maGi203kuMgu; Tue, 23 Sep 2014 22:54:24 +0200 X-ME-Helo: CHOUNEK X-ME-Date: Tue, 23 Sep 2014 22:54:24 +0200 X-ME-IP: 90.32.172.128 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.12.242.131 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:174675 Archived-At: --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Answers below... ---------------------------------------- > From: schwab@linux-m68k.org > To: vincent.b.1@hotmail.fr > Subject: Re: Patch to allow texi2any for EMACS manual compilation > Date: Mon, 22 Sep 2014 20:59:48 +0200 > CC: pertusus@free.fr; karl@freefriends.org; eggert@cs.ucla.edu; emacs-dev= el@gnu.org > > Vincent Bela=EFche writes: > > > =3D=3D=3D modified file 'configure.ac' > > --- configure.ac 2014-09-15 00:20:21 +0000 > > +++ configure.ac 2014-09-22 17:36:48 +0000 > > @@ -1099,16 +1099,25 @@ > > > > ## Need makeinfo >=3D 4.7 (?) to build the manuals. > > if test "$MAKEINFO" !=3D "no"; then > > - if test "$MAKEINFO" =3D "${am_missing_run}makeinfo"; then > > - MAKEINFO=3Dmakeinfo > > + for MAKEINFO_IMPLEMENTATION in makeinfo texi2any; do > > + if test "$MAKEINFO" =3D "${am_missing_run}${MAKEINFO_IMPLEMENTATION}"= ; then > > + MAKEINFO=3D${MAKEINFO_IMPLEMENTATION} > > + fi > > + done > > + MAKEINFO_VERSION=3D`($MAKEINFO --version) 2>/dev/null`; > > + MAKEINFO_CHECK=3Dno; > > + for MAKEINFO_IMPLEMENTATION in makeinfo texi2any; do > > + case $MAKEINFO_VERSION in > > + "$MAKEINFO_IMPLEMENTATION (GNU texinfo) "4.[7-9]* | \ > > + "$MAKEINFO_IMPLEMENTATION (GNU texinfo) "4.[1-9][0-9]* | \ > > + "$MAKEINFO_IMPLEMENTATION (GNU texinfo) "[5-9]* | \ > > + "$MAKEINFO_IMPLEMENTATION (GNU texinfo) "[1-9][0-9]* ) > > + MAKEINFO_CHECK=3Dyes;; > > + esac > > + done > > + if [ $MAKEINFO_CHECK !=3D yes ]; then > > + MAKEINFO=3Dno; > > fi > > - case `($MAKEINFO --version) 2>/dev/null` in > > - 'makeinfo (GNU texinfo) '4.[[7-9]]* | \ > > - 'makeinfo (GNU texinfo) '4.[[1-9][0-9]]* | \ > > - 'makeinfo (GNU texinfo) '[[5-9]]* | \ > > - 'makeinfo (GNU texinfo) '[[1-9][0-9]]* ) ;; > > Why can't you just replace it with a wildcard? What's the point in > matching the exact program name? > There is a version number checking. So we rely on the fact that texi2any and makeinfo have both: - consistent version numbers: C based makeinfo version does not go beyond 4.99 (AFAIK last version is 4.13), while texi2any starts at 5.0 - consistent command line, texi2any command line is a superset of that makeinfo. Now, yes it would be possible to use a wildecard, given that it is quite unlikely than there are other alternative to makeinfo than texi2any. To make it slightly more restictive, wildcard could be ???????? instead of * because makeinfo & texi2any both have 8 letters. BTW, when I did the patch I initially thought that my problem was with using a fake makeinfo that is indeed a skin of texi2any. But it came out that this was not the only issue. Current configure.ac uses that sort of wildcard: [[7-9]] with [...] encapsulation around `[7-9]'. This does not work for me and I did not found any such thing in the manual: http://www.gnu.org/software/bash/manual/bashref.html#pattern-matching so I removed also that encapsulation as in the attached patch. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=configure.ac.diff === modified file 'configure.ac' --- configure.ac 2014-09-15 00:20:21 +0000 +++ configure.ac 2014-09-23 20:42:43 +0000 @@ -1103,10 +1103,11 @@ MAKEINFO=makeinfo fi case `($MAKEINFO --version) 2>/dev/null` in - 'makeinfo (GNU texinfo) '4.[[7-9]]* | \ - 'makeinfo (GNU texinfo) '4.[[1-9][0-9]]* | \ - 'makeinfo (GNU texinfo) '[[5-9]]* | \ - 'makeinfo (GNU texinfo) '[[1-9][0-9]]* ) ;; + # ???????? matches both makeinfo & texi2any + ????????' (GNU texinfo) '4.[7-9]* | \ + ????????' (GNU texinfo) '4.[1-9][0-9]* | \ + ????????' (GNU texinfo) '[5-9]* | \ + ????????' (GNU texinfo) '[1-9][0-9]* ) ;; *) MAKEINFO=no;; esac fi --=-=-= Content-Type: text/plain If people agree with this patch I can do the change. VBR, Vincent. > Andreas. > > -- > Andreas Schwab, schwab@linux-m68k.org > GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 > "And now for something completely different." > --=-=-=--