From: Paul Eggert <eggert@cs.ucla.edu>
To: Robert Pluim <rpluim@gmail.com>
Cc: Stephen Gildea <stepheng+emacs@gildea.com>, emacs-devel@gnu.org
Subject: Re: master 32d1c1f: ; Grammar in simple.el doc strings and comments
Date: Sun, 17 Nov 2019 15:31:54 -0800 [thread overview]
Message-ID: <8072150e-4a69-0a11-53c6-e03ddbfd3c29@cs.ucla.edu> (raw)
In-Reply-To: <m2pnhqcpqx.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
On 11/17/19 10:38 AM, Robert Pluim wrote:
> these changes do nothing to
> improve the clarity or quality of the documentation.
To my eyes those patches actually improved doc quality slightly; I wouldn't have
complained about them, at any rate.
I would go even further in one place, and did so by installing the attached.
[-- Attachment #2: 0001-lisp-simple.el-process-file-Clarify-doc-string.patch --]
[-- Type: text/x-patch, Size: 1508 bytes --]
From 0b47d731c08d0d5d4ba4a0c31f9be1152fd8c2c8 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sun, 17 Nov 2019 15:26:55 -0800
Subject: [PATCH] * lisp/simple.el (process-file): Clarify doc string.
---
lisp/simple.el | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/lisp/simple.el b/lisp/simple.el
index 8229899f9a..c61ccd511c 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -4007,14 +4007,13 @@ process-file
If PROGRAM is a remote file name, it should be processed
by `file-local-name' before passing it to this function.
-File names in INFILE and BUFFER are handled normally, but file
-names in ARGS should be relative to `default-directory', as they
-are passed to the process verbatim. (This is a difference from
-`call-process', which does not support file name handlers for INFILE
-and BUFFER.)
-
-Some file name handlers might not support all variants, for example
-they might behave as if DISPLAY was nil, regardless of the actual
+Handle file names in INFILE and BUFFER normally; this differs
+from `call-process', which does not support file name handlers
+for INFILE and BUFFER. However, pass ARGS to the process
+verbatim without file name handling, as `call-process' does.
+
+Some file name handlers might not support all variants. For
+example, they might treat DISPLAY as nil regardless of the actual
value passed."
(let ((fh (find-file-name-handler default-directory 'process-file))
lc stderr-file)
--
2.17.1
prev parent reply other threads:[~2019-11-17 23:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191117052033.32701.18626@vcs0.savannah.gnu.org>
[not found] ` <20191117052035.30EC0209BF@vcs0.savannah.gnu.org>
2019-11-17 18:38 ` master 32d1c1f: ; Grammar in simple.el doc strings and comments Robert Pluim
2019-11-17 23:31 ` Paul Eggert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8072150e-4a69-0a11-53c6-e03ddbfd3c29@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=rpluim@gmail.com \
--cc=stepheng+emacs@gildea.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.