f90 indentation error and annoyance

f90 indentation error and annoyance

[Dave Love]

In a buffer in f90-mode, run indent-region on the following two lines
to get an error.  It fails with any main that doesn't start with
`program':

print 'foo'
end

I find it annoying that indenting an `end' statement always qualifies
it.  That should be customizable, and I think the default should be
not to.  E.g. indenting this:

program main
  print 'foo'
end

produces:

program main
  print 'foo'
end program main

Re: f90 indentation error and annoyance

[Glenn Morris]

Dave Love wrote:

> In a buffer in f90-mode, run indent-region on the following two lines
> to get an error.  It fails with any main that doesn't start with
> `program':
>
> print 'foo'
> end
>
> I find it annoying that indenting an `end' statement always qualifies
> it.  That should be customizable, and I think the default should be
> not to.

It is customizable - set f90-smart-end to nil. The doc for that
variable is not very clear, though, so I'll improve it. Setting it to
nil also avoids your bug, but I will look for a proper fix.

Re: f90 indentation error and annoyance

[Dave Love]

Glenn Morris <gmorris+emacs@ast.cam.ac.uk> writes:

> It is customizable - set f90-smart-end to nil.

I thought it didn't used to happen for me...  I actually checked the
code, but I must have looked at the wrong level.  (You wouldn't guess
I was once muggins for it :-/.)

> The doc for that variable is not very clear, though,

Indeed.

> so I'll improve it. Setting it to
> nil also avoids your bug, but I will look for a proper fix.

I think blinking the block start ought to be orthogonal to inserting
the extra text.  I still think the latter shouldn't be the default
since it does more than indent the line.

I think f90-mode generally tries to be too clever rather than just
obeying the normal conventions, but I never had time to tidy it up.
E.g. TAB should work via indent-line-function rather than being
rebound directly to f90-indent-line.

Re: f90 indentation error and annoyance

[Glenn Morris]

Dave Love wrote:

> In a buffer in f90-mode, run indent-region on the following two
> lines to get an error. It fails with any main that doesn't start
> with `program':
>
> print 'foo'
> end

OK, I have at last checked a fix for such cases into CVS. It was a wee
bit hacky (indentation, blech) so please let me know if it still fails
in some cases.