From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: wsnyder@wsnyder.org (Wilson Snyder) Newsgroups: gmane.emacs.devel Subject: Re: Comment in verilog-mode.el about supported versions Date: Mon, 19 Dec 2016 08:37:10 -0500 Message-ID: <7q37hk82gp.fsf@emma.svaha.wsnyder.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1482154651 14413 195.159.176.226 (19 Dec 2016 13:37:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 19 Dec 2016 13:37:31 +0000 (UTC) Cc: emacs-devel@gnu.org, tino.calancha@gmail.com, kaushal.modi@gmail.com To: Noam Postavsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 19 14:37:23 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIy83-0002Dx-I9 for ged-emacs-devel@m.gmane.org; Mon, 19 Dec 2016 14:37:23 +0100 Original-Received: from localhost ([::1]:45590 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIy86-00040C-D9 for ged-emacs-devel@m.gmane.org; Mon, 19 Dec 2016 08:37:26 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIy7z-000406-LP for emacs-devel@gnu.org; Mon, 19 Dec 2016 08:37:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cIy7w-00065g-Gs for emacs-devel@gnu.org; Mon, 19 Dec 2016 08:37:19 -0500 Original-Received: from vpo3.wsnyder.org ([173.230.154.183]:49957 helo=wsnyder.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIy7w-000658-AU for emacs-devel@gnu.org; Mon, 19 Dec 2016 08:37:16 -0500 X-ssh-sendmail: true X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 173.230.154.183 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210629 Archived-At: >> On Mon, Dec 19, 2016, 5:19 PM Tino Calancha wrote: >>> >>> in the comentary of >>> lisp/progmodes/verilog-mode.el >>> you can find following comment: >>> ;; This code supports Emacs 21.1 and later >>> ;; And XEmacs 21.1 and later >>> ;; Please do not make changes that break Emacs 21. Thanks! >>> >>> I could understand this comment in a version of this file >>> elsewhere, e.g. ELPA, but not in the built-in version in Emacs. >>> Why is this comment needed? >>> Is it OK to drop from the master branch this kind of comments? Please retain this, this entire file is identical with that used on other versions of Emacs. It would be otherwise be nearly impossible to manage diverging files. >This reminds me, I posted a patch to fix a bug in verilog-mode, but >left it unapplied because I wasn't sure about backwards compatibility: >https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23842#62 Thanks for your improvements. It's perhaps reasonable to break a small number of things in say Emacs 21, but this patch also breaks Emacs 23.1, which is still relatively widely deployed for those on Redhat distros, such as at my employer. Perhaps the patch can be made backward compatible by e.g. having verilog-complete-word be a defmacro to call the standard functions when they are defined? There's a bunch of similar hackary see the many eval-and-compile blocks. I'm not personally familiar with the completion part of verilog-mode nor the related Emacs functions, or I'd do it. -Wilson