From: Glenn Morris <rgm@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: Stephen Berman <stephen.berman@gmx.net>, 18381@debbugs.gnu.org
Subject: bug#18381: 24.3.93; Diary can wrongly be displayed in Calendar's window
Date: Thu, 04 Sep 2014 14:04:07 -0400 [thread overview]
Message-ID: <7lr3zrjm94.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <54085AC5.5050304@gmx.at> (martin rudalics's message of "Thu, 04 Sep 2014 14:27:49 +0200")
martin rudalics wrote:
> ... is the same window where you first show the calendar here. As a
> consequence, `display-buffer-in-previous-window' will find a window
> where you have shown `diary' already and reuse that window. I'm not
> sure what's the best thing to do here - maybe we should remove
> `display-buffer-in-previous-window' from
> `display-buffer-fallback-action' in `calendar-in-read-only-buffer'.
The most conservative fix would seem to be to only change
calendar-basic-setup, where it calls diary-view-entries.
I guess what we really want to say is "don't display the diary in the
window that you just displayed the calendar in" (is that possible?), but
failing that, simply removing display-buffer-in-previous-window seems to
work. What's the cleanest way to do that? Binding
display-buffer-overriding-action or display-buffer-fallback-action
to an explicit list? display-buffer-fallback-action does not have the
friendliest format to make "remove element X" straightforward,
and is marked as a constant.
*** lisp/calendar/calendar.el 2014-03-17 16:04:32 +0000
--- lisp/calendar/calendar.el 2014-09-04 17:57:25 +0000
***************
*** 1432,1438 ****
(calendar-generate-window month year)
(if (and calendar-view-diary-initially-flag
(calendar-date-is-visible-p date))
! (diary-view-entries))))
(if calendar-view-holidays-initially-flag
(let* ((diary-buffer (get-file-buffer diary-file))
(diary-window (if diary-buffer (get-buffer-window diary-buffer)))
--- 1432,1444 ----
(calendar-generate-window month year)
(if (and calendar-view-diary-initially-flag
(calendar-date-is-visible-p date))
! (let ((display-buffer-fallback-action
! '((display-buffer--maybe-same-window
! display-buffer-reuse-window
! display-buffer--maybe-pop-up-frame-or-window
! display-buffer-use-some-window
! display-buffer-pop-up-frame))))
! (diary-view-entries)))))
(if calendar-view-holidays-initially-flag
(let* ((diary-buffer (get-file-buffer diary-file))
(diary-window (if diary-buffer (get-buffer-window diary-buffer)))
next prev parent reply other threads:[~2014-09-04 18:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 14:59 bug#18381: 24.3.93; Diary can wrongly be displayed in Calendar's window Stephen Berman
2014-09-01 17:37 ` Glenn Morris
2014-09-01 18:38 ` Stephen Berman
2014-09-04 0:34 ` Glenn Morris
2014-09-04 12:27 ` martin rudalics
2014-09-04 18:04 ` Glenn Morris [this message]
2014-09-04 19:48 ` Glenn Morris
2014-09-04 22:39 ` Glenn Morris
2014-09-04 23:40 ` Glenn Morris
2014-09-05 10:46 ` martin rudalics
2014-09-05 16:14 ` Glenn Morris
2014-09-06 8:52 ` martin rudalics
2014-09-08 6:04 ` Glenn Morris
2014-09-08 20:32 ` Stephen Berman
2014-09-09 1:26 ` Glenn Morris
2014-09-09 6:58 ` martin rudalics
2014-09-09 7:44 ` Glenn Morris
2014-09-09 9:18 ` martin rudalics
2014-09-09 18:13 ` Glenn Morris
2014-09-09 13:00 ` Stefan Monnier
2014-09-05 10:46 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7lr3zrjm94.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=18381@debbugs.gnu.org \
--cc=rudalics@gmx.at \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.