From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#10208: site-lisp directories in load-path after --no-site-lisp Date: Tue, 10 Jan 2012 20:08:19 -0500 Message-ID: <7j7h0zrqpo.fsf@fencepost.gnu.org> References: <87ipkrw8y7.fsf@Rainer.invalid> <87zke0mr38.fsf@Rainer.invalid> <87ipknfn2v.fsf@Rainer.invalid> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1326244132 1997 80.91.229.12 (11 Jan 2012 01:08:52 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 11 Jan 2012 01:08:52 +0000 (UTC) Cc: 10208@debbugs.gnu.org To: Achim Gratz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 11 02:08:46 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RkmgH-0006RI-By for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Jan 2012 02:08:45 +0100 Original-Received: from localhost ([::1]:55946 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkmgG-0005it-JF for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Jan 2012 20:08:44 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:48976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkmgD-0005io-Fm for bug-gnu-emacs@gnu.org; Tue, 10 Jan 2012 20:08:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RkmgC-000853-6e for bug-gnu-emacs@gnu.org; Tue, 10 Jan 2012 20:08:41 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkmgC-00084z-55 for bug-gnu-emacs@gnu.org; Tue, 10 Jan 2012 20:08:40 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1RkmgY-0003gb-7r for bug-gnu-emacs@gnu.org; Tue, 10 Jan 2012 20:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Jan 2012 01:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10208 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10208-submit@debbugs.gnu.org id=B10208.132624412614145 (code B ref 10208); Wed, 11 Jan 2012 01:09:02 +0000 Original-Received: (at 10208) by debbugs.gnu.org; 11 Jan 2012 01:08:46 +0000 Original-Received: from localhost ([127.0.0.1]:53028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RkmgI-0003g4-0V for submit@debbugs.gnu.org; Tue, 10 Jan 2012 20:08:46 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]:54750) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RkmgE-0003fv-LD for 10208@debbugs.gnu.org; Tue, 10 Jan 2012 20:08:44 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Rkmfr-0005RP-9L; Tue, 10 Jan 2012 20:08:19 -0500 X-Spook: crypto anarchy ANC USDOJ Al-Qaeda BCCI codes 2600 X-Ran: Y~fpz$w`z&~hgT:FZc+el%YS*iE-$1:2{6J-c{ur*)1[vRC%ZG6 (Achim Gratz's message of "Sat, 07 Jan 2012 18:18:32 +0100") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:55624 Archived-At: Achim Gratz wrote: > The whole incantation that removes the site-lisp from load-path is > safeguarded with "if (!NILP (Vinstallation_directory))", so for the > installed Emacs the --no-site-lisp option is never actually acted upon, > since installation-directory is nil. Thanks for tracking this down, I installed something similar. I had not appreciated half of what init_lread does, nor that installation-directory is actually nil in installed Emacs (and would be better named "build-directory" IMO). AFAICS, there are still the following issues: i) EMACSLOADPATH overrides --no-site-lisp; it probably should not. ii) This presumably means --no-site-lisp does not work in --with-ns builds, since they set load-path via EMACSLOADPATH (IMO, it's a bug that one part of Emacs uses an env-var just to communicate with another, see eg http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6401#48 ) These could both be solved by simply removing any Vload_path element matching "site-lisp" near the end of init_lread. (I guess this would remove the need for the MS Windows build to implement this feature separately as well.) This would still leave: iii) Any --enable-locallisppath element that does not happen to have "site-lisp" in its name will not get removed (but such elements already mess things up because they will break the sorting of load-path that init_lread tries to do). Perhaps it would be better to split PATH_LOADSEARCH in epaths.h into a default and site-lisp component, and simply not add the latter with --no-site-lisp. Finally, I noticed that you have some changes installed (for Org) that are not marked as "tiny changes", yet you don't seem to have a copyright assignment. IF you have not completed one, are you willing to do so? The process is straightforward.