tramp: plain ftp problem

tramp: plain ftp problem

[Kin Cho]

Hi,

I'm running tramp 2.0.35.

I wanted to ftp to a box (called "guiness") which supports ftp.
The box supports ssh too, but the tramp startup overhead is a bit
much and I like to avoid typing passwords which scp requires :(.

I used this sytax: /ftp:root@guiness:/knbt/

The dired listing works fine.  However, I got an error retrieving
a file ("log") from the dired listing.

If I eval this at the top level:

(file-symlink-p "/ftp:root@guiness:/knbt/log")

I simply got nil.

If I don't load tramp, ange-ftp works fine retrieving the same
file.

I'm using:

GNU Emacs 21.3.1 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2003-04-21 on nscldt26

Thanks.

-kin

Debugger entered--Lisp error: (ftp-error "FTP Error: OPEN request failed: ftp: ftp: Name or service not known")
  signal(ftp-error ("FTP Error: OPEN request failed: ftp: ftp: Name or service not known"))
  ange-ftp-error("ftp" "kin" "OPEN request failed: ftp: ftp: Name or service not known")
  ange-ftp-normal-login("ftp" "kin" "123" "" #<process *ftp kin@ftp*>)
  ange-ftp-get-process("ftp" "kin")
  ange-ftp-host-type("ftp" "kin")
  ange-ftp-expand-dir("ftp" "kin" "~")
  ange-ftp-canonize-filename("/ftp:root@guiness:/knbt/log")
  ange-ftp-expand-file-name("/ftp:root@guiness:/knbt/log" nil)
  apply(ange-ftp-expand-file-name ("/ftp:root@guiness:/knbt/log" nil))
  ange-ftp-hook-function(expand-file-name "/ftp:root@guiness:/knbt/log" nil)
  apply(ange-ftp-hook-function expand-file-name ("/ftp:root@guiness:/knbt/log" nil))
  tramp-ftp-file-name-handler(expand-file-name "/ftp:root@guiness:/knbt/log" nil)
  apply(tramp-ftp-file-name-handler expand-file-name ("/ftp:root@guiness:/knbt/log" nil))
  tramp-file-name-handler(expand-file-name "/ftp:root@guiness:/knbt/log" nil)
  file-symlink-p("/ftp:root@guiness:/knbt/log")
  vc-find-file-hook()
  run-hooks(find-file-hooks)
  after-find-file(nil t)
  find-file-noselect-1(#<buffer log> "/ftp:root@guiness:/knbt/log" nil nil "/ftp:root@guiness:/knbt/log" (2 -1))
  find-file-noselect("/ftp:root@guiness:/knbt/log" nil nil nil)
  ad-Orig-find-file("/ftp:root@guiness:/knbt/log" nil)
  (setq ad-return-value (ad-Orig-find-file filename wildcards))
  (let (ad-return-value) (setq ad-return-value (ad-Orig-find-file filename wildcards)) ad-return-value)
  find-file("/ftp:root@guiness:/knbt/log")
  dired-advertised-find-file()
  call-interactively(dired-advertised-find-file)

Re: tramp: plain ftp problem

[Kai Großjohann]

Kin Cho <kin@techie.com> writes:

> Debugger entered--Lisp error: (ftp-error "FTP Error: OPEN request failed: ftp: ftp: Name or service not known")
>   signal(ftp-error ("FTP Error: OPEN request failed: ftp: ftp: Name or service not known"))
>   ange-ftp-error("ftp" "kin" "OPEN request failed: ftp: ftp: Name or service not known")
>   ange-ftp-normal-login("ftp" "kin" "123" "" #<process *ftp kin@ftp*>)

It is trying to connect to the host ftp.  This means that
ange-ftp-name-format has the wrong value, I think.  Can you check the
value of ange-ftp-name-format at that spot?

The regular expression should allow for two colons in the line and
should generally look similar to the Tramp regexp.

Also, please check the variable file-name-handler-alist.  Is ange-ftp
mentioned there?  It shouldn't.
-- 
This line is not blank.

Re: tramp: plain ftp problem

[Kin Cho]

Michael Albinus <Michael.Albinus@alcatel.de> writes:

> IIRC, this problem has been fixed already in Emacs CVS some weeks
> ago. Pls try that ange-ftp.el.

The HEAD version of the main branch fixed my problem.  Thanks!

-kin

Re: tramp: plain ftp problem

[Kin Cho]

Hi,

> Michael Albinus <Michael.Albinus@alcatel.de> writes:
> 
> > IIRC, this problem has been fixed already in Emacs CVS some weeks
> > ago. Pls try that ange-ftp.el.
> 
> The HEAD version of the main branch fixed my problem.  Thanks!

The HEAD version (Tue Jun 24 10:46:11 2003) of the main branch of
ange-ftp-generate-root-prefixes seems to have a problem.  It
returns a list instead of a list of lists as expected by
all-completions (called by ange-ftp-file-name-all-completions).

-kin

--- ange-ftp.el-orig	Tue Jun 24 10:46:11 2003
+++ ange-ftp.el	Sat Jun 28 09:26:37 2003
@@ -1402,10 +1402,10 @@
 	 (if (string-match "^[^/]*\\(/\\).*$" key)
 	     (let ((host (substring key 0 (match-beginning 1)))
 		   (user (substring key (match-end 1))))
-	       (push (concat user "@" host ":") res))))
+	       (push (list (concat user "@" host ":")) res))))
        ange-ftp-passwd-hashtable)
       (maphash
-       (lambda (host user) (push (concat host ":") res))
+       (lambda (host user) (push (list (concat host ":")) res))
        ange-ftp-user-hashtable)
       (or res (list nil)))))

Re: tramp: plain ftp problem

[Kai Großjohann]

Kin Cho <kin@techie.com> writes:

> The HEAD version (Tue Jun 24 10:46:11 2003) of the main branch of
> ange-ftp-generate-root-prefixes seems to have a problem.  It
> returns a list instead of a list of lists as expected by
> all-completions (called by ange-ftp-file-name-all-completions).

I think I agree, but before I commit this, could you tell me how to
reproduce the problem?

I just ran (file-name-all-completions "d" "/ftp@ftp:/") and got
("debian/") which seems to be right (and agrees with the root of that
server).

I also used TAB for completion via Ange-FTP.
-- 
~/.signature

Re: tramp: plain ftp problem

[Kin Cho]

kai.grossjohann@gmx.net (Kai Großjohann) writes:

> Kin Cho <kin@techie.com> writes:
> 
> > The HEAD version (Tue Jun 24 10:46:11 2003) of the main branch of
> > ange-ftp-generate-root-prefixes seems to have a problem.  It
> > returns a list instead of a list of lists as expected by
> > all-completions (called by ange-ftp-file-name-all-completions).
> 
> I think I agree, but before I commit this, could you tell me how to
> reproduce the problem?
> 
> I just ran (file-name-all-completions "d" "/ftp@ftp:/") and got
> ("debian/") which seems to be right (and agrees with the root of that
> server).
> 
> I also used TAB for completion via Ange-FTP.

I think I did a PC-complete with "/fo" in the minibuffer.

For some reason in my work environment here, I don't see
ange-ftp-file-name-all-completions getting called at all.

I'll try it at home later and find out what's the stack trace.

-kin

Re: tramp: plain ftp problem

[Kin Cho]

kai.grossjohann@gmx.net (Kai Großjohann) writes:

> > The HEAD version (Tue Jun 24 10:46:11 2003) of the main branch of
> > ange-ftp-generate-root-prefixes seems to have a problem.  It
> > returns a list instead of a list of lists as expected by
> > all-completions (called by ange-ftp-file-name-all-completions).
> 
> I think I agree, but before I commit this, could you tell me how to
> reproduce the problem?

I've included the stack trace I got when I run this at home.  For
some reason ange-ftp-generate-root-prefixes doesn't get called at
all here at work.  I'm using the same customization scripts and
emacs version in both environments.

Thanks.

-kin

ange-ftp-generate-root-prefixes()
(all-completions file (ange-ftp-generate-root-prefixes))
(nconc (all-completions file (ange-ftp-generate-root-prefixes)) (ange-ftp-real-file-name-all-completions file ange-ftp-this-dir))
(if (ange-ftp-root-dir-p ange-ftp-this-dir) (nconc (all-completions file ...) (ange-ftp-real-file-name-all-completions file ange-ftp-this-dir)) (ange-ftp-real-file-name-all-completions file ange-ftp-this-dir))
(if (ange-ftp-ftp-name ange-ftp-this-dir) (progn (ange-ftp-barf-if-not-directory ange-ftp-this-dir) (setq ange-ftp-this-dir ...) (let* ... ...)) (if (ange-ftp-root-dir-p ange-ftp-this-dir) (nconc ... ...) (ange-ftp-real-file-name-all-completions file ange-ftp-this-dir)))
(let ((ange-ftp-this-dir ...)) (if (ange-ftp-ftp-name ange-ftp-this-dir) (progn ... ... ...) (if ... ... ...)))
ange-ftp-file-name-all-completions("fo" "/")
apply(ange-ftp-file-name-all-completions ("fo" "/"))
(progn (apply fn args))
(unwind-protect (progn (apply fn args)) (set-match-data save-match-data-internal))
(let ((save-match-data-internal ...)) (unwind-protect (progn ...) (set-match-data save-match-data-internal)))
(save-match-data (apply fn args))
(if fn (save-match-data (apply fn args)) (ange-ftp-run-real-handler operation args))
(let ((fn ...)) (if fn (save-match-data ...) (ange-ftp-run-real-handler operation args)))
ange-ftp-hook-function(file-name-all-completions "fo" "/")
apply(ange-ftp-hook-function file-name-all-completions ("fo" "/"))
ange-ftp-completion-hook-function(file-name-all-completions "fo" "/")
#<subr read-file-name-internal>("/fo" "/home/kin/" t)
read-file-name-internal("/fo" "/home/kin/" t)
all-completions("/fo" read-file-name-internal "/home/kin/")
PC-do-completion(nil)
PC-complete()
call-interactively(PC-complete)