make mostlyclean

make mostlyclean

[Glenn Morris]

In src/, `make mostlyclean' removes (amongst other things)
"bootstrap-emacs", but it does not remove "emacs-22.0.91" (sans build
number), which is a hardlink to "bootstrap-emacs". Should it not
delete that file as well? It is the biggest file in src/ by some
margin in my build tree.

Maybe this is tricky because src/Makefile does not have the variable
EMACSFULL with the version number from the top-level Makefile...

Re: make mostlyclean

[Richard Stallman]

    In src/, `make mostlyclean' removes (amongst other things)
    "bootstrap-emacs", but it does not remove "emacs-22.0.91" (sans build
    number), which is a hardlink to "bootstrap-emacs". Should it not
    delete that file as well? It is the biggest file in src/ by some
    margin in my build tree.

I think this is correct.  If you build Emacs again it will get a new
number.

Re: make mostlyclean

[Glenn Morris]

Richard Stallman wrote:

>     In src/, `make mostlyclean' removes (amongst other things)
>     "bootstrap-emacs", but it does not remove "emacs-22.0.91" (sans build
>     number), which is a hardlink to "bootstrap-emacs". Should it not
>     delete that file as well? It is the biggest file in src/ by some
>     margin in my build tree.
>
> I think this is correct.  If you build Emacs again it will get a new
> number.

I either did not explain or misunderstood. The file I am referring to
does not have a number.

The bootstrap sequence goes:

Dumping under names emacs and emacs-22.0.91
mv -f emacs bootstrap-emacs
...do stuff using bootstrap-emacs...
make mostlyclean
  rm -f bootstrap-emacs
Dumping under names emacs and emacs-22.0.91.1

At the end, I have:

emacs and emacs-22.0.91.1  (hard links, 13 MB)
emacs-22.0.91              (20MB, was a hard link to bootstrap-emacs)

If bootstrap-emacs gets deleted, surely emacs-22.0.91 (without ".1" at
the end) should too?

Re: make mostlyclean

[Richard Stallman]

    If bootstrap-emacs gets deleted, surely emacs-22.0.91 (without ".1" at
    the end) should too?

That would be logical, I agree.

Re: make mostlyclean

[Glenn Morris]

Richard Stallman wrote:

> That would be logical, I agree.

Logic may be satisfied at the cost of aesthetics, by adding `version'
to src/Makefile:


*** Makefile.in	15 Sep 2006 07:19:14 -0000	1.331
--- Makefile.in	2 Dec 2006 02:41:42 -0000
***************
*** 38,43 ****
--- 38,44 ----
  LDFLAGS=@LDFLAGS@
  LN_S=@LN_S@
  EXEEXT=@EXEEXT@
+ version=@version@
  # Substitute an assignment for the MAKE variable, because
  # BSD doesn't have it as a default.
  @SET_MAKE@
***************
*** 1309,1319 ****
  ${libsrc}emacstool${EXEEXT}: ${libsrc}emacstool.c
  	cd ${libsrc}; ${MAKE} ${MFLAGS} emacstool${EXEEXT}
  bootstrapclean:
! 	rm -f bootstrap-emacs${EXEEXT}
  mostlyclean:
  	rm -f temacs${EXEEXT} prefix-args${EXEEXT} core *.core \#* *.o libXMenu11.a liblw.a
  	rm -f ../etc/DOC
! 	rm -f bootstrap-emacs${EXEEXT}
  	rm -f buildobj.lst
  clean: mostlyclean
  	rm -f emacs-*${EXEEXT} emacs${EXEEXT}
--- 1310,1320 ----
  ${libsrc}emacstool${EXEEXT}: ${libsrc}emacstool.c
  	cd ${libsrc}; ${MAKE} ${MFLAGS} emacstool${EXEEXT}
  bootstrapclean:
! 	rm -f bootstrap-emacs${EXEEXT} emacs-${version}${EXEEXT}
  mostlyclean:
  	rm -f temacs${EXEEXT} prefix-args${EXEEXT} core *.core \#* *.o libXMenu11.a liblw.a
  	rm -f ../etc/DOC
! 	rm -f bootstrap-emacs${EXEEXT} emacs-${version}${EXEEXT}
  	rm -f buildobj.lst
  clean: mostlyclean
  	rm -f emacs-*${EXEEXT} emacs${EXEEXT}

Re: make mostlyclean

[Richard Stallman]

This change looks good.