From: Brennan Vincent <brennan@umanwizard.com>
To: 61521@debbugs.gnu.org
Subject: bug#61521: "default" is now the first item returned from (font-faces), breaking various code.
Date: Tue, 14 Feb 2023 19:31:30 -0500 [thread overview]
Message-ID: <7fe5e80d-761f-cc2d-12a1-65b2b5781c39@umanwizard.com> (raw)
Various code seems to expect "default" to be the /last/ item in the list
returned by that function, not the first. For example, this comment in faces.el:
;; The `reverse' is so that `default' goes first.
(dolist (face (nreverse (face-list)))
Also, org-html-htmlize-generate-css does not work when default comes first in
the list (as it skips processing all fonts after default).
I am not sure why this was changed and if the change was intentional, but it can
be fixed by changing the "<" to a ">" in the last line of face-list, so I
suspect it might have been a mistake.
diff --git lisp/faces.el lisp/faces.el
index 4933b495a6c..e998dc504e5 100644
--- lisp/faces.el
+++ lisp/faces.el
@@ -199,7 +199,7 @@ face-list
(maphash (lambda (face spec)
(push `(,(car spec) . ,face) faces))
face--new-frame-defaults)
- (mapcar #'cdr (sort faces (lambda (f1 f2) (< (car f1) (car f2)))))))
+ (mapcar #'cdr (sort faces (lambda (f1 f2) (> (car f1) (car f2)))))))
(defun make-face (face)
"Define a new face with name FACE, a symbol.
next reply other threads:[~2023-02-15 0:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 0:31 Brennan Vincent [this message]
2023-02-15 0:52 ` bug#61521: "default" is now the first item returned from (font-faces), breaking various code Brennan Vincent
2023-02-15 1:00 ` Gregory Heytings
2023-02-15 1:06 ` Brennan Vincent
2023-02-15 9:00 ` Gregory Heytings
2023-02-15 13:43 ` Eli Zaretskii
2023-02-15 14:11 ` Gregory Heytings
2023-02-17 22:17 ` Kai Ma
2023-02-18 6:49 ` Eli Zaretskii
2023-02-18 6:54 ` Kai Ma
2023-02-18 7:40 ` Eli Zaretskii
2023-02-15 12:58 ` Eli Zaretskii
2023-02-15 14:01 ` Brennan Vincent
2023-02-15 14:19 ` Gregory Heytings
2023-02-15 14:24 ` Eli Zaretskii
2023-02-15 16:19 ` Brennan Vincent
2023-02-17 8:29 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fe5e80d-761f-cc2d-12a1-65b2b5781c39@umanwizard.com \
--to=brennan@umanwizard.com \
--cc=61521@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.