From: Douglas Lewan <d.lewan2000@gmail.com>
To: Emanuel Berg <moasenwood@zoho.eu>,
help-gnu-emacs <help-gnu-emacs@gnu.org>
Subject: Re: wrong type error in local variables
Date: Thu, 2 Jul 2020 21:40:16 -0400 [thread overview]
Message-ID: <7fa40d4a-f713-9771-a7ed-8cb83e24bf59@gmail.com> (raw)
In-Reply-To: <877dvlpf83.fsf@ebih.ebihd>
On 7/2/20 9:19 PM, Emanuel Berg via Users list for the GNU Emacs text
editor wrote:
> Stefan Monnier wrote:
>
>>>> `find-file` should not be called from Elisp.
>>>> Use `find-file-noselect` instead.
>>> Oups, if so I have 15 changes to make. Why doesn't
>>> the byte compiler say this?
>> Because noone has added the annotation for it yet
>> (tho there are various comments in the code that
>> say so).
> Okay, but what exactly is the problem with it,
> from Lisp?
>
The problem is that it changes the buffer.
If a (find-file) fails and you were depending on the change of the
current buffer all kinds of other things might go wrong.
If you use (find-file-noselect), then the current buffer doesn't change
and any attempt to use that buffer would fail. In particular, you should
be verifying that the (find-file-noselect) succeeded.
--
,Doug
d.lewan2000@gmail.com
(908) 720 7908
If this is what winning looks like, I'd hate to see what losing is.
next prev parent reply other threads:[~2020-07-03 1:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 14:46 wrong type error in local variables Douglas Lewan
2020-07-02 15:06 ` Joost Kremers
2020-07-02 15:59 ` Douglas Lewan
2020-07-02 15:56 ` Stefan Monnier
2020-07-02 16:36 ` Emanuel Berg via Users list for the GNU Emacs text editor
2020-07-02 17:09 ` Douglas Lewan
2020-07-02 17:45 ` Emanuel Berg via Users list for the GNU Emacs text editor
2020-07-02 17:42 ` Stefan Monnier
2020-07-03 1:19 ` Emanuel Berg via Users list for the GNU Emacs text editor
2020-07-03 1:40 ` Douglas Lewan [this message]
2020-07-03 2:00 ` Emanuel Berg via Users list for the GNU Emacs text editor
2020-07-03 2:24 ` Douglas Lewan
2020-07-03 3:45 ` Emanuel Berg via Users list for the GNU Emacs text editor
2020-07-03 5:13 ` Douglas Lewan
2020-07-03 6:05 ` Emanuel Berg via Users list for the GNU Emacs text editor
2020-07-02 17:04 ` Douglas Lewan
2020-07-02 17:15 ` Douglas Lewan
-- strict thread matches above, loose matches on Subject: below --
2020-07-03 8:33 Anders Munch
2020-07-03 10:36 ` Emanuel Berg via Users list for the GNU Emacs text editor
2020-07-03 14:07 ` Douglas Lewan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fa40d4a-f713-9771-a7ed-8cb83e24bf59@gmail.com \
--to=d.lewan2000@gmail.com \
--cc=help-gnu-emacs@gnu.org \
--cc=moasenwood@zoho.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.