bug#28864: 25.3.50; next-error-no-select does select

[Dmitry Gutov <dgutov@yandex.ru>]

On 10/22/17 11:32 PM, Juri Linkov wrote:

> Visiting a buffer should not set next-error-last-buffer,
> it should be set only by an explicit user request,
> like M-x compile/grep/rgrep/occur and other commands do.
 >
> So please just remove setting of next-error-last-buffer
> from change-log-mode.

Why not remove it from compilation-start as well? And 
xref--xref-buffer-mode.

After all, the user can visit the results buffer and press M-x 
next-error just as well.

> We also have other issues with next-error in bug#20489
> where I'm waiting when Dmitry will send a comprehensive list
> of possible scenarios, so we could find a solution that fits
> all of them.

I had no idea that someone is waiting for something like that. Is there 
a question in the bug discussion that I'd missed?

My scenario template is basically this:

1. Visit a buffer <A> in some major mode, press M-x next-error or M-x 
previous-error an arbitrary number of times, visiting the appropriate 
error locations, whether they are in the current buffer or in some other 
buffers or files that will have to be opened.

2. The above should happen fine irrespective of the current window 
configuration, and whether the buffer <A> gets hidden for some reason 
during this process (and we do know the possible reasons).

3. Being able to open a different buffer <B>, *somehow* switch to its 
error function, and have M-x next-error and M-x previous-error use it.

4. Being able to go to step 1 without much hassle.

Please ask any further questions.

> 4. When the user needs to switch to visiting ChangeLog entries
>     from the ChangeLog buffer, this can be achieved by typing
>     C-c C-c (change-log-goto-source) once, then all subsequent
>     M-g M-n will continue visiting next ChangeLog entries
>     in the source files.

As solutions go, it's a step forward.

But far from ideal: generally speaking, it requires a separate command 
and a binding in each suitable major mode that will switch to its 
next-error-function.