From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Federico Beffa Newsgroups: gmane.emacs.bugs Subject: bug#73500: eglot: diagnostic location not always shown Date: Mon, 30 Sep 2024 17:45:32 +0200 Message-ID: <7f2a2749-f12a-4611-bb1d-671fc8d299b3@fbengineering.ch> References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------Ik4CuC7MtgR3PspldC6eURDT" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35255"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: 73500@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 30 17:46:56 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1svIbv-0008zr-5S for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Sep 2024 17:46:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1svIbl-0002Xh-MT; Mon, 30 Sep 2024 11:46:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svIbW-0002WU-C9 for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 11:46:31 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1svIbW-00007R-37 for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 11:46:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=s+UWNDD6eldp6oEUaBqy4lF27h0Xv48UGmI4rFrXC5k=; b=ViHqbXxHKc166SJSLtjjZ6oxVbb3iioaSv6vV0M5nK1ugK4Q+BOvEoPuBASGOuI4u5d9Zvz0a1WOsAsEt3vz9zjM7QnSc1mYX2+jKQBLCX93sK1UsAhb2L8xou7Ne3BZLP5OBz5DRHoPZswob47VQ0UIBD4csvn3Y2PIl5lmGCDYGe3BVl5RPI3PMC31fhcinQKNDIKeQEAwbkqcWZMHCafpTiNF5OKCKCvu9TTjeVV59YUEoRJvSNrpvfKVGJb5QjIqOSPyVtAjTZx8xdd0YIyNyBG4OxX3Q2p8Akm0o5OhA7pCbo03gkCysBW5icDDQIg5+uFbDOxvd7gvFqJzmA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1svIc2-0000RJ-RU for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 11:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Federico Beffa Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Sep 2024 15:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73500 X-GNU-PR-Package: emacs Original-Received: via spool by 73500-submit@debbugs.gnu.org id=B73500.17277112071621 (code B ref 73500); Mon, 30 Sep 2024 15:47:02 +0000 Original-Received: (at 73500) by debbugs.gnu.org; 30 Sep 2024 15:46:47 +0000 Original-Received: from localhost ([127.0.0.1]:45532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svIbn-0000Q5-18 for submit@debbugs.gnu.org; Mon, 30 Sep 2024 11:46:47 -0400 Original-Received: from smtp-42ad.mail.infomaniak.ch ([84.16.66.173]:55861) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svIbi-0000PF-S9 for 73500@debbugs.gnu.org; Mon, 30 Sep 2024 11:46:45 -0400 Original-Received: from smtp-4-0001.mail.infomaniak.ch (smtp-4-0001.mail.infomaniak.ch [10.7.10.108]) by smtp-4-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4XHQQ54tLYzPyb for <73500@debbugs.gnu.org>; Mon, 30 Sep 2024 17:45:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fbengineering.ch; s=20220212; t=1727711133; bh=s+UWNDD6eldp6oEUaBqy4lF27h0Xv48UGmI4rFrXC5k=; h=Date:Subject:References:To:From:In-Reply-To:From; b=YrGgK9lZDm0SDqjjaX2FfoZWvTUn7PTHdNF2p6In2o1mChZTe2VRIhOdYlYsxtB8y 2nvZOFxV01D20lu68wnJAsTeZjeGyIlBSYMT8FVBoOXqkzJwwxWF362bkShSfjhFPj PoUEyyc9xOJlaY/+rxH5I6mwT3GqdA1tbYH8wPb4= Original-Received: from unknown by smtp-4-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4XHQQ51cbszBjp for <73500@debbugs.gnu.org>; Mon, 30 Sep 2024 17:45:32 +0200 (CEST) Content-Language: en-US Autocrypt: addr=federico.beffa@fbengineering.ch; keydata= xsBNBFgAga0BCADIY78eSt/I4vGPo/UMBMQhcM8O2tptvlN0B2F6Z8sDAOwgWnQpd0x2AVM8 I39VymnmbEQfWf/Y0U9XJqrmOz91NreTsZUsR9BSZy1fVIUbdoQTI8m8CGpjDBnloX+cQwwD PDS2RL2/a0rZciXUMunVvM/o2zLHUIyO/GeoqKN5mU4d4nZYPHtBOBpmzfvfyZLM1uyu/flb KGFqW0uKmS8MQWhyUdvIsiAU/Aofuf0dVp2C/Z5w01Vyw38fReZ20onxbabSjLrOT+K6vzrV /9P+6435Ptoek+5BoQX50f+cMYq4d2rE2PBenDy4xAloL/qOUj6XqwW9ZWAkLLiqYiJdABEB AAHNMEZlZGVyaWNvIEJlZmZhIDxmZWRlcmljby5iZWZmYUBmYmVuZ2luZWVyaW5nLmNoPsLA kQQTAQgAOxYhBDd0gCSID9P/3KLJq1iTbg4vG1pMBQJjXqXsAhsDBQsJCAcCAiICBhUKCQgL AgQWAgMBAh4HAheAAAoJEFiTbg4vG1pMv1sH/1K4SI0+6tmpPLGwCUqpeUk5AScmqntZ41rT 9W8XF1QgZVsgSqFrVfQLpW+MC5VoMJJmdcPLD8gLLBhViavw8LrQzO8jO90US70MnUnniFB7 c0YabBsd2cGa25a+LOZ/f1lZCtHvlq46Trxcn9DM+pfexlM6AyN8+FGGIstSwXC96AOfr41U lSQqaLbD9ecf+VzPvOPozKLOpQaakuUFLeo9KB1VmK3UxWU3JQ96fJ+Aw8PXJLJFH8bSK/an OCzZPPFvICGUcqBKIDirUKzRyiC In-Reply-To: X-Forwarded-Message-Id: X-Infomaniak-Routing: alpha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292722 Archived-At: This is a multi-part message in MIME format. --------------Ik4CuC7MtgR3PspldC6eURDT Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit -------- Forwarded Message -------- Subject: Re: bug#73500: eglot: diagnostic location not always shown Date: Mon, 30 Sep 2024 12:16:53 +0200 From: Federico Beffa To: João Távora On 30/09/2024 11:41, João Távora wrote: > On Mon, Sep 30, 2024 at 10:19 AM Federico Beffa > wrote: >> A few questions: >> * have you checked the provided lsp*.log files which show that the diagnostics is sent? > Yes. But I don't get that log, as I already showed. >> * have you checked the provided screenshots showing an exclamation mark in the fringe but no underlining? > These are not from emacs -Q so I ignored them. For all I know you may have a > (imaginary-bugs) in your init file. Or have a different setting of the > underlining face > to something that can't be rendered. > > A screenshot of a clean Emacs -Q would have been slightly more useful (well > not really useful, but more interesting at least). They are, I just enabled manually in the session the wombat theme because I prefer dark ones. >> * How do you explain the exclamation mark in the fringe which doess not appear if eglot is not enabled? > That's an odd question. I don't, of course. Much as I can't "explain" > that grainy > footage that someone says they took of bigfoot. Maybe bigfoot exists, maybe > it's just a far away hunchback person. I'll have a better change of > "explaining" something once I can investigate it myself, and so far > I haven't been able to reproduce your sighting. > >> * Do you also see the exclamation mark in the fringe on the line in question? > No, when I tried your Emacs -Q recipe I didn't see any diagnostics. I > thought I > explained that. > >> * Does "cabal run" works? Do you see the output? If not please provide the complete error message. > Eglot doesn't interact with cabal, it interacts via LSP with > haskell-language-server. Nobody said that eglot interacts with cabal. It's the `haskell-language-server` that does...  and, as I told several times, without cabal you don't get any warning and hence the diagnostics. > I can tell you I managed a successful interaction where the server in question > connected perfectly and analized the Main.hs program you provided. When > Tweaking the program, I got some diagnostics. As far as I'm concerned > witnessed first hand in an Emacs -Q session, Eglot correctly underlines all > diagnostics coming from that server, which is not suprising to me, since > they look a lot like any other diagnostic coming from any other server and > Eglot doesn't care about the provenance of diagnostics. > > Also, I uninstalled everything haskell, it bloated up my system and I don't plan > on installing it again.. > > João From all your previous replies I expected these answers. Dismissing bug reports without making any serious effort to reproduce them just makes a disservice to your own and to the Emacs projects. Never mind, I wanted to help the project, but I'll move on to other less buggy and more feature reach options. --------------Ik4CuC7MtgR3PspldC6eURDT Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit


-------- Forwarded Message --------
Subject: Re: bug#73500: eglot: diagnostic location not always shown
Date: Mon, 30 Sep 2024 12:16:53 +0200
From: Federico Beffa <federico.beffa@fbengineering.ch>
To: João Távora <joaotavora@gmail.com>


On 30/09/2024 11:41, João Távora wrote:
On Mon, Sep 30, 2024 at 10:19 AM Federico Beffa
<federico.beffa@fbengineering.ch> wrote:

A few questions:
* have you checked the provided lsp*.log files which show that the diagnostics is sent?

Yes.  But I don't get that log, as I already showed.

* have you checked the provided screenshots showing an exclamation mark in the fringe but no underlining?

These are not from emacs -Q so I ignored them. For all I know you may have a
(imaginary-bugs) in your init file. Or have a different setting of the
underlining face
to something that can't be rendered.

A screenshot of a clean Emacs -Q would have been slightly more useful (well
not really useful, but more interesting at least).

They are, I just enabled manually in the session the wombat theme because I prefer dark ones.

* How do you explain the exclamation mark in the fringe which doess not appear if eglot is not enabled?

That's an odd question.  I don't, of course. Much as I can't "explain"
that grainy
footage that someone says they took of bigfoot.  Maybe bigfoot exists, maybe
it's just a far away hunchback person.  I'll have a better change of
"explaining" something once I can investigate it myself, and so far
I haven't been able to reproduce your sighting.


* Do you also see the exclamation mark in the fringe on the line in question?

No, when I tried your Emacs -Q recipe I didn't see any diagnostics.  I
thought I
explained that.


* Does "cabal run" works? Do you see the output? If not please provide the complete error message.

Eglot doesn't interact with cabal, it interacts via LSP with
haskell-language-server.

Nobody said that eglot interacts with cabal. It's the `haskell-language-server` that does...  and, as I told several times, without cabal you don't get any warning and hence the diagnostics.

I can tell you I managed a successful interaction where the server in question
connected perfectly and analized the Main.hs program you provided.  When
Tweaking the program, I got some diagnostics.  As far as I'm concerned
witnessed  first hand in an Emacs -Q session, Eglot correctly underlines all
diagnostics coming from that server, which is not suprising to me, since
they look a lot like any other diagnostic coming from  any other server and
Eglot doesn't care about the provenance of diagnostics.

Also, I uninstalled everything haskell, it bloated up my system and I don't plan
on installing it again..

João

From all your previous replies I expected these answers. Dismissing bug reports without making any serious effort to reproduce them just makes a disservice to your own and to the Emacs projects. Never mind, I wanted to help the project, but I'll move on to other less buggy and more feature reach options.
--------------Ik4CuC7MtgR3PspldC6eURDT--