From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62416: 30.0.50; Symbols skipped in the navigation in ruby-ts-mode Date: Sun, 26 Mar 2023 05:14:35 +0300 Message-ID: <7f03efd3-b3d8-2a93-3414-63a7a2604943@yandex.ru> References: <9cfb677e-2c3b-94f3-e09f-8b231dd9b8f5@yandex.ru> <86v8iomzk3.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6824"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Cc: =?UTF-8?Q?Bo=C5=A1ko_?= =?UTF-8?Q?Ivani=C5=A1evi=C4=87?= , 62416@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 26 04:15:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgFuo-0001WD-5r for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Mar 2023 04:15:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pgFuT-00047F-KQ; Sat, 25 Mar 2023 22:15:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgFuR-00046q-Fu for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 22:15:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pgFuR-0000bF-1n for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 22:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pgFuQ-0004bM-Ds for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 22:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Mar 2023 02:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62416 X-GNU-PR-Package: emacs Original-Received: via spool by 62416-submit@debbugs.gnu.org id=B62416.167979688717648 (code B ref 62416); Sun, 26 Mar 2023 02:15:02 +0000 Original-Received: (at 62416) by debbugs.gnu.org; 26 Mar 2023 02:14:47 +0000 Original-Received: from localhost ([127.0.0.1]:43731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgFuA-0004aa-JT for submit@debbugs.gnu.org; Sat, 25 Mar 2023 22:14:46 -0400 Original-Received: from mail-wm1-f53.google.com ([209.85.128.53]:35546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgFu9-0004aN-EG for 62416@debbugs.gnu.org; Sat, 25 Mar 2023 22:14:45 -0400 Original-Received: by mail-wm1-f53.google.com with SMTP id bg16-20020a05600c3c9000b003eb34e21bdfso5308277wmb.0 for <62416@debbugs.gnu.org>; Sat, 25 Mar 2023 19:14:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679796878; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=wNO1iU1oTZf8v9D5J/jv/WodeXbtS28ouIfgFE0GrT4=; b=GM6ybgjHnWHd4yL7HnkyAEj2RjrPEuJ/jix6J3QtNb3QX12xHAZIQ2BUdtGHTg2VYu ABn239/79WDhEY9cR3c5XtOQpPVJwqkS1JrZub3a21fSMtFskhoumibASiqhTQ+zXWT3 9tPYMiSmhwLO3r8FljZtIStt6zJIS8lIanhzA/W7OiQL06b0SUH1+BI509RplQ8VRqoB z+/Cl+XCltzI2P6GXIhyNIjYVGKaBmtWK9SQG6B0haw8PYOGrMb/cWT4WZWIkyzcn62r WEr2iOhskBsGw6jvaU/hgYV4lazVXBrIBHuwcZ6B0rt41B8PQLCNf3kLu3hU4pMN6MMZ oWfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679796878; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wNO1iU1oTZf8v9D5J/jv/WodeXbtS28ouIfgFE0GrT4=; b=oizcXcr3O+aVaQP0zj2KbCuvsP9nl3Dn3aUTfzGFChxaGsuWYCcsJnVpGv+CFKsYl4 p4xDzNmtZ7r3V4poIA96et92zYQrOdjoybENi9hkxFqnTRt+N9hSlWN73beb9YTLPCJA Ml0X8AX/FKQ0J5xddtfXL3ID0QHZHwL55LyWKoHOy9JIg0MbhINdOCykgOggWUZvUtQh auAg4CFE2EumlfMKKKAIaOSLV6sSpzsqYGbga1d4vKXPBmnOOax3pO7rdAKUMvTKTnHI fD9Qj0hZJD81LxX4K+v/7rY071wv/xGUcKNoaE/ahFE1qx1LwLtmYQ3Ca87ejjHepaMh ymJw== X-Gm-Message-State: AO0yUKWSU18La+lnoVvHVcnq/37BXn46ssqtteeo2I5JR9YBO+MCBsup hvaeJBQFBh1p0T4BUxR1LkA= X-Google-Smtp-Source: AK7set/Ojapoe+6sQv1fDM806SYEbNWqw8rSOm6H7WRZQpvGwbLvSf+JlfnzBkz8AJqKZTq+kh7lbg== X-Received: by 2002:a7b:c4d7:0:b0:3ed:a07b:c591 with SMTP id g23-20020a7bc4d7000000b003eda07bc591mr5836045wmk.1.1679796878185; Sat, 25 Mar 2023 19:14:38 -0700 (PDT) Original-Received: from [192.168.0.2] ([85.132.229.92]) by smtp.googlemail.com with ESMTPSA id w6-20020a05600c474600b003ede04deb14sm4304745wmo.48.2023.03.25.19.14.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Mar 2023 19:14:37 -0700 (PDT) Content-Language: en-US In-Reply-To: <86v8iomzk3.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258642 Archived-At: On 25/03/2023 21:04, Juri Linkov wrote: >>> Navigating word forward/backward skips the Ruby symbol in the ruby-ts-mode. >>> Adding "simple_symbol" to the treesit-sexp-type-regexp is fixing it. >>>   (setq-local treesit-sexp-type-regexp >>>               (regexp-opt '("class" >>>                             "module" >>>                             "method" >>>                             "argument_list" >>>                             "array" >>>                             "hash" >>>                             "parenthesized_statements" >>>                             "if" >>>                             "case" >>>                             "when" >>>                             "block" >>>                             "do_block" >>>                             "begin" >>>                             "binary" >>>                             "simple_symbol" ;; <-- missing >>>                             "assignment"))) >> >> Juri, what do you think? >> >> In the context of your previous feedback regarding sexp navigation in >> ruby-ts-mode. > > This is fine. Good. Let's push it into master. > But anyway I think in its current state > treesit-sexp-type-regexp is underdesigned as noted in > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62238#59 > so no tweaking could fix its design flaws. For example, > > foo = { > a: b > } > > when point is on the left curly bracket, 'C-M-f C-M-b' doesn't > move back to the original position, etc. Hm, yeah, it's a little unexpected that not only it doesn't move back exactly, it skips the full assignment expression in both directions. What is the downside of dropping "binary" and "assignment" from treesit-sexp-type-regexp, added there not too long ago? Without "assignment" there, your example becomes a round-trip. BTW, we should wrap the regexp with \`...\'. It currently does substring matching, that's why it also matches "identifier" (which should probably be added too).