From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Tue, 25 May 2021 02:24:03 +0300 Message-ID: <7ecb37f0-8301-a8a1-7585-2e42f99be94c@yandex.ru> References: <87zgwlb4xc.fsf@gmail.com> <617d06ca-27bf-2ae8-26eb-1042123499d3@daniel-mendler.de> <87pmxhb1rs.fsf@gmail.com> <87czthnhne.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19074"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 Cc: Daniel Mendler , "emacs-devel@gnu.org" , =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= , monnier@iro.umontreal.ca To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 25 01:25:17 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llJwi-0004qw-Uh for ged-emacs-devel@m.gmane-mx.org; Tue, 25 May 2021 01:25:16 +0200 Original-Received: from localhost ([::1]:50768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llJwh-0001Km-S7 for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 19:25:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llJvd-0000XX-1j for emacs-devel@gnu.org; Mon, 24 May 2021 19:24:09 -0400 Original-Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:41810) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llJvb-0006VS-4d for emacs-devel@gnu.org; Mon, 24 May 2021 19:24:08 -0400 Original-Received: by mail-wr1-x42b.google.com with SMTP id d11so30128416wrw.8 for ; Mon, 24 May 2021 16:24:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OQfbnWYQyeSgawhrN+VVwU/J1913OuptJ36lrMatmRI=; b=Q0vxdYRoBoGyiXK2Z5GS4KClkZVP2sMPqOOz5ozQRgYtlp97vB8W3+C8kQG/VazdlG LDRm8ysoTuPhkGzONRwDBTrv6KPTENXQcZZxxAG9rPcpnwfVaMopoFHYUWAn+SApb9o/ ZphMllTNIIlx56bPKZR5l/vqn2/oCvz8DXuUyzGoRnCO0UKp/vXluPLdWPJdYiB7IfN7 Z3yFeLci0Q/k4hXfc0slrMSEXa5P1LCgWjEk7GqPC0W4Rw17g+HWeybAWjsYWSVCmBbO Itjsuoy4AOZub/KeKZMpX9ublkD7779AnNUH1pmn61uhabY3PtzeAoCTYl7gPC/uXhYX T9DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OQfbnWYQyeSgawhrN+VVwU/J1913OuptJ36lrMatmRI=; b=qWgY//85TIQ+ALOdHOrHzRB268NzpGPf09QE6gqcksaz4uIUGkGE+scaUOVHOKG1NW BJF94u7J0Kua5jWR1akSGNiGF69XiNx1GnYWwwqUfQ/EzhpZUrRwTbZ3YojjCCOXuUVJ 1ziN80SYUSPr+Q9ifjgPfxLXjgdG34yGS4u/cDQYLnWrsluIcqbPn0otgRXZX2IUKnnX 9YCARtrjdivd6tXnkRwp2S0hZMoNJaIIsOm+Vf8KiM2y4lueJQfQ9+qSNjVPcIKnMHKL ipa2MThvtAhzBIV3pQKazjH3smORPUUuokmxIceO9Sii47p2EQ8LN3EICB+MPUvtp55g 1omA== X-Gm-Message-State: AOAM532byyo5NbUAlFDGv21Cyzrr9pxWMRfhaJL4iPXqir9yPaWmKOyc RVL6cJdNyFlNaOG1SFZV2Vh4Ufovzhk= X-Google-Smtp-Source: ABdhPJyKk8OdQrIL8g5vCVdGMRYqYtn4Ol39oqJvSgMV/eOYm6DTswFaF9nDn6d3lq6kX09w+mJcBA== X-Received: by 2002:a5d:6910:: with SMTP id t16mr23893282wru.416.1621898645328; Mon, 24 May 2021 16:24:05 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id n6sm8757586wmq.34.2021.05.24.16.24.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 16:24:04 -0700 (PDT) In-Reply-To: <87czthnhne.fsf@mail.linkov.net> Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=raaahh@gmail.com; helo=mail-wr1-x42b.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269823 Archived-At: On 24.05.2021 02:42, Juri Linkov wrote: > And later your reply was that annotation-function is the old approach, and > that the default completion frontend still doesn't use :company-kind. > Any plans to add support for :company-kind to the default frontend? I can try and write an experimental patch if people are interested. But it would be better if it was then brought over the "finish line" by someone who regularly uses 'M-x completion-at-point'. Because this feature, applied to the UI in a general fashion, brings usability questions and I'm sure will trigger some old-timer concerns. Consider Elisp completion. Currently we only show annotation when the context is such that it is not certain that the completion is a function (e.g. the completions set is symbols which can be anything). But when all completions are functions, we don't show . The current company-kind implementation is informed by the expectations of IDE users, where the kind is always shown. We also split functions into special forms and "regular" functions, annotating the former as "keywords", to make it not entirely useless even in this context. I do believe this is beneficial, but I'm also sure that not every user is going to like seeing or in the first column for all completions, always. Not at first, at least.