From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#30938: 27.0; `dired-do-create-files' etc.: do NOT always raise error if no files Date: Sun, 25 Mar 2018 09:36:08 -0700 (PDT) Message-ID: <7ea429b5-b12e-4639-9d77-11db71504d9c@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1521995719 31373 195.159.176.226 (25 Mar 2018 16:35:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 25 Mar 2018 16:35:19 +0000 (UTC) To: 30938@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 25 18:35:15 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f08bz-00082v-0v for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Mar 2018 18:35:15 +0200 Original-Received: from localhost ([::1]:51880 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f08e0-0001OG-DE for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Mar 2018 12:37:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38614) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f08dl-0001Mh-ML for bug-gnu-emacs@gnu.org; Sun, 25 Mar 2018 12:37:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f08di-00087w-Da for bug-gnu-emacs@gnu.org; Sun, 25 Mar 2018 12:37:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45233) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f08di-00087k-94 for bug-gnu-emacs@gnu.org; Sun, 25 Mar 2018 12:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f08dh-0003vb-TJ for bug-gnu-emacs@gnu.org; Sun, 25 Mar 2018 12:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Mar 2018 16:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 30938 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.152199578615053 (code B ref -1); Sun, 25 Mar 2018 16:37:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 25 Mar 2018 16:36:26 +0000 Original-Received: from localhost ([127.0.0.1]:53130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f08d8-0003ui-GF for submit@debbugs.gnu.org; Sun, 25 Mar 2018 12:36:26 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:47365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f08d6-0003uT-Iu for submit@debbugs.gnu.org; Sun, 25 Mar 2018 12:36:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f08d0-0007EY-Bg for submit@debbugs.gnu.org; Sun, 25 Mar 2018 12:36:19 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:46583) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f08d0-0007Du-95 for submit@debbugs.gnu.org; Sun, 25 Mar 2018 12:36:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f08cy-000172-W7 for bug-gnu-emacs@gnu.org; Sun, 25 Mar 2018 12:36:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f08cu-000782-Vk for bug-gnu-emacs@gnu.org; Sun, 25 Mar 2018 12:36:17 -0400 Original-Received: from userp2130.oracle.com ([156.151.31.86]:49050) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f08cu-00075Q-Ku for bug-gnu-emacs@gnu.org; Sun, 25 Mar 2018 12:36:12 -0400 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w2PGU9Vs191357 for ; Sun, 25 Mar 2018 16:36:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=vwT1jUhTgHKtpq+7rBgDXgkKx5lGcJ2NdG/+TYyLtB4=; b=VFhRwUThb7rO8C+WRsEAJKsAds+Nu0G7dqkG+SoONNsi9fByiRX1sZGpSooIDjpo6nSo 4vD2eFtxWPB5YKSVfdgCLdjuT0Y+prfJtb69xswAnrz26SkWKyyJoNvrAB/AP+6+9TiF nZWcsvv7q5WsMln6SU19gn1yijL6dEPzQ94dYHVbX1W5PT3UG0z7cxMAXbixuZWYchNs s/gb/jcC4W38sItpS/+ZgeQo6VDp6K5WGqST3f064SaO7rohDd41PAsey8FQhMPwm7BI Hov9+hHIMSL59bZoG7Zn6zaIj57Z3RQzJSNRPQe2A/m9r1KzVa75Ctp9Jd8z7tNwh4UG 6Q== Original-Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2130.oracle.com with ESMTP id 2gxf5r8123-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 25 Mar 2018 16:36:09 +0000 Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w2PGa9sH009837 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 25 Mar 2018 16:36:09 GMT Original-Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w2PGa8jq030048 for ; Sun, 25 Mar 2018 16:36:09 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4666.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8843 signatures=668695 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=869 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803250197 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144602 Archived-At: Emacs 27 has introduced an unfortunate incompatible change. It has added an extra optional arg, ERROR, to `dired-get-marked-files', which is fine. The bug is that calls to `dired-get-marked-files' have been changed all over the place to systematically pass a non-nil value for optional arg ERROR. In general, this is completely inappropriate when the command invoking `dired-get-marked-files' is not called interactively. There is NO reason to suppose that a `user-error' occurred when a given command is invoked non-interactively. The logic behind this change is wrong - much too simplistic. A non-nil ERROR arg should perhaps be passed when called from some commands, but typically only when such a command is called interactively. Only then might Emacs legitimately assume (and even this is arguable, in general) that the user has committed an error. Please revert this change as soon as possible, while you look for a better way to do what you intended to do for it. Please do not impose raising such a user error on commands when they are not invoked interactively. It is perfectly reasonable for some such commands to be invoked when there are no marked files, in which case the action should typically be a no-op - it should not be to raise an error (much less a "user" error). In GNU Emacs 27.0.50 (build 3, x86_64-w64-mingw32) of 2018-03-21 Repository revision: e70d0c9e66d7a8609450b2889869d16aeb0363b5 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install -C 'CFLAGS=3D-O2 -static -g3''