From: "Andrew L. Moore" <slewsys@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 54218@debbugs.gnu.org
Subject: bug#54218: [PATCH] Magic number regexp shouldn't match beyond end-of-line.
Date: Thu, 3 Mar 2022 14:57:06 -0500 [thread overview]
Message-ID: <7e9735e1-308a-237b-0466-f702a4e94a59@gmail.com> (raw)
In-Reply-To: <87ilsvhzbw.fsf@gnus.org>
On 3/3/22 09:42, Lars Ingebrigtsen wrote:
> "Andrew L. Moore" <slewsys@gmail.com> writes:
>
>> Repeat magic number search to work around match-data loss
>> when `save-window-excursion' is called.
>
> I think it would perhaps make more sense to just save the match data
> instead of repeating the match, so I've now done so in Emacs 29
Yes, this resolves the issues that I was seeing.
For the record, I'm not able to reproduce the data loss with
vanilla Emacs by calling `executable-set-magic' manually. It
occurs (for me) when `executable-set-magic' is called automatically
from a minor mode. In any case, your patch fixes my minor mode
and does no harm.
The other issue that I attributed to the regexp matching beyond
EOL was caused by `replace-match' being called by incorrect or
uninitialized match data. Your patch resolves this as well.
Thank you!
next prev parent reply other threads:[~2022-03-03 19:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 4:52 bug#54218: [PATCH] Magic number regexp shouldn't match beyond end-of-line Andrew L. Moore
2022-03-02 8:23 ` Andreas Schwab
2022-03-03 14:42 ` Lars Ingebrigtsen
2022-03-03 19:57 ` Andrew L. Moore [this message]
2022-03-04 15:37 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e9735e1-308a-237b-0466-f702a4e94a59@gmail.com \
--to=slewsys@gmail.com \
--cc=54218@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.