From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: lists@dima.secretsauce.net, 51497@debbugs.gnu.org,
larsi@gnus.org, wolfgang.scherer@gmx.de
Subject: bug#51497: 29.0.50; (vc-print-log) broken over TRAMP
Date: Sat, 6 Nov 2021 22:44:55 +0300 [thread overview]
Message-ID: <7e04f090-81de-d5bd-746c-7f09ed0c38b0@yandex.ru> (raw)
In-Reply-To: <831r3tb7un.fsf@gnu.org>
On 06.11.2021 18:51, Eli Zaretskii wrote:
>> From: Dmitry Gutov <dgutov@yandex.ru>
>> Cc: 51497@debbugs.gnu.org, Wolfgang Scherer <wolfgang.scherer@gmx.de>,
>> Dima Kogan <lists@dima.secretsauce.net>
>> Date: Sat, 6 Nov 2021 16:22:56 +0300
>>
>> On 03.11.2021 15:06, Dmitry Gutov wrote:
>>> Lars, Eli, can we put it in Emacs 28?
>>
>> Ping.
>
> Sorry for missing the original question.
>
> I'm a bit worried by the function relying on the fact that
> default-directory is the directory of the repository. Wouldn't it be
> better to explicitly let-bind it inside the function?
We could, but notice how most of vc-git-* functions don't bind
default-directory, thus relying on its implicit value. It just how VC
works: expecting default-directory to have the right value around the calls.
The only current caller of vc-git--program-version (vc-git-state) does
not either. The backend methods that do, seem to do that with some
additional purpose (like having default-directory point to the
repository root, rather than be a random directory inside it).
> A (perhaps safer) alternative for emacs-28 would be not to use
> :(literal) for remote repositories. What are the disadvantages of
> that?
That would mean leaving bug#39452 unfixed on remote hosts. Seems like a
significant disadvantage to me (inconsistent behavior leads to more
difficult reproduction and reporting of bugs, in particular for those
who will notice this problem remotely but would not be able to reproduce
locally). Given that the code complexity added by fixing this bug would
remain with us, seems more like worst-of-both-worlds kind of situation.
But it would make VC work on remote CentOS 7 hosts again, there's that.
next prev parent reply other threads:[~2021-11-06 19:44 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-30 1:24 bug#51497: 29.0.50; (vc-print-log) broken over TRAMP dima
2021-10-30 12:48 ` Lars Ingebrigtsen
2021-10-30 13:21 ` Dmitry Gutov
2021-10-30 19:01 ` Dima Kogan
2021-10-31 0:56 ` Dmitry Gutov
2021-10-31 6:58 ` Dima Kogan
2021-10-31 8:16 ` Michael Albinus
2021-10-31 12:26 ` Dmitry Gutov
2021-10-31 16:05 ` Michael Albinus
2021-11-03 2:00 ` Dmitry Gutov
2021-11-03 17:09 ` Michael Albinus
2021-11-05 2:00 ` Dmitry Gutov
2021-11-03 2:03 ` Dmitry Gutov
2021-11-03 3:03 ` Dima Kogan
2021-11-03 12:06 ` Dmitry Gutov
2021-11-06 13:22 ` Dmitry Gutov
2021-11-06 15:51 ` Eli Zaretskii
2021-11-06 19:44 ` Dmitry Gutov [this message]
2021-11-06 19:52 ` Eli Zaretskii
2021-11-06 22:11 ` Andy Moreton
2021-11-06 22:21 ` Dmitry Gutov
2021-11-06 23:03 ` Andy Moreton
2021-11-07 0:11 ` Dmitry Gutov
2021-11-07 6:47 ` Eli Zaretskii
2021-11-07 10:43 ` Andy Moreton
2021-11-07 22:36 ` Dmitry Gutov
2021-11-08 12:49 ` Eli Zaretskii
2021-11-08 17:30 ` Dmitry Gutov
2021-11-08 18:18 ` Eli Zaretskii
2021-12-23 10:28 ` Lars Ingebrigtsen
2021-12-26 0:53 ` Dmitry Gutov
2021-12-27 1:36 ` Dmitry Gutov
2022-01-03 3:59 ` Dmitry Gutov
2022-01-03 21:15 ` Dima Kogan
2022-01-03 22:51 ` Dmitry Gutov
2022-01-04 3:28 ` Eli Zaretskii
2022-01-05 2:09 ` Dmitry Gutov
2022-01-21 13:50 ` Lars Ingebrigtsen
2022-01-21 14:11 ` Dmitry Gutov
2022-01-03 21:16 ` Andy Moreton
2021-11-07 6:43 ` Eli Zaretskii
2021-11-07 10:45 ` Andy Moreton
2021-11-07 6:31 ` Eli Zaretskii
2021-11-06 22:19 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e04f090-81de-d5bd-746c-7f09ed0c38b0@yandex.ru \
--to=dgutov@yandex.ru \
--cc=51497@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
--cc=lists@dima.secretsauce.net \
--cc=wolfgang.scherer@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.