From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#22847: #17062: 24.3 current-fill-column breaks fill-match-adaptive-prefix Date: Thu, 08 Dec 2016 17:32:38 -0500 Message-ID: <7dvauuyruh.fsf@fencepost.gnu.org> References: <56D3F443.9000706@easy-emacs.de> <83si0b8q7t.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1481236394 3744 195.159.176.226 (8 Dec 2016 22:33:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 8 Dec 2016 22:33:14 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) To: 22847@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 08 23:33:10 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cF7FV-0008Sc-2A for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Dec 2016 23:33:09 +0100 Original-Received: from localhost ([::1]:49581 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cF7FZ-0005it-4Q for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Dec 2016 17:33:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cF7FP-0005id-IK for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2016 17:33:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cF7FO-0003Wk-Rj for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2016 17:33:03 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47789) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cF7FO-0003Wd-OK for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2016 17:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cF7FO-0005Pp-I0 for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2016 17:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Dec 2016 22:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22847 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 22847-submit@debbugs.gnu.org id=B22847.148123636620785 (code B ref 22847); Thu, 08 Dec 2016 22:33:02 +0000 Original-Received: (at 22847) by debbugs.gnu.org; 8 Dec 2016 22:32:46 +0000 Original-Received: from localhost ([127.0.0.1]:34955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cF7F8-0005PB-1F for submit@debbugs.gnu.org; Thu, 08 Dec 2016 17:32:46 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:36637) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cF7F7-0005Ox-2z for 22847@debbugs.gnu.org; Thu, 08 Dec 2016 17:32:45 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cF7F1-0003SA-5u for 22847@debbugs.gnu.org; Thu, 08 Dec 2016 17:32:39 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47153) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cF7F1-0003S6-3D for 22847@debbugs.gnu.org; Thu, 08 Dec 2016 17:32:39 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1cF7F0-00065S-I4; Thu, 08 Dec 2016 17:32:38 -0500 X-Spook: PET Drug Administration Consular Recovery Albanian X-Ran: :x5#/GD-TdQd,hpLHb48 X-Hue: yellow X-Attribution: GM In-Reply-To: <83si0b8q7t.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 29 Feb 2016 17:56:54 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126755 Archived-At: So this seems like a mess. fill-column is documented to be an integer, and that is its custom-type. Nowhere does it say it can be nil, AFAICS. Many places in Emacs are not prepared for it (or current-fill-column) to be nil. Yet 1e87252 explicitly added a check for a nil fill-column to current-fill-column. AFAICS, do-auto-fill is the only place in Emacs that tests for this, and uses it to disable auto-fill. The only uses I find for "(setq fill-column nil)" are a few people using it in their .emacs to disable auto-fill (I guess) in some major mode. The idiomatic way to do this is just to turn off auto-fill in that mode. TLDR: Let's remove the test for nil fill-column in current-fill-column.