From: Glenn Morris <rgm@gnu.org>
To: 22847@debbugs.gnu.org
Subject: bug#22847: #17062: 24.3 current-fill-column breaks fill-match-adaptive-prefix
Date: Thu, 08 Dec 2016 17:32:38 -0500 [thread overview]
Message-ID: <7dvauuyruh.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <83si0b8q7t.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 29 Feb 2016 17:56:54 +0200")
So this seems like a mess.
fill-column is documented to be an integer, and that is its custom-type.
Nowhere does it say it can be nil, AFAICS.
Many places in Emacs are not prepared for it (or current-fill-column) to
be nil.
Yet 1e87252 explicitly added a check for a nil fill-column to
current-fill-column. AFAICS, do-auto-fill is the only place in Emacs
that tests for this, and uses it to disable auto-fill.
The only uses I find for "(setq fill-column nil)" are a few people using
it in their .emacs to disable auto-fill (I guess) in some major mode.
The idiomatic way to do this is just to turn off auto-fill in that mode.
TLDR:
Let's remove the test for nil fill-column in current-fill-column.
next prev parent reply other threads:[~2016-12-08 22:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 7:33 bug#22847: #17062: 24.3 current-fill-column breaks fill-match-adaptive-prefix Andreas Röhler
2016-02-29 15:56 ` Eli Zaretskii
2016-12-08 22:32 ` Glenn Morris [this message]
2016-12-09 8:08 ` Eli Zaretskii
2016-12-11 2:18 ` Glenn Morris
2020-08-15 5:14 ` Stefan Kangas
2021-05-10 11:48 ` Lars Ingebrigtsen
2021-05-10 13:29 ` Stefan Kangas
2021-05-12 13:25 ` Lars Ingebrigtsen
2021-07-23 12:58 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dvauuyruh.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=22847@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.