From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#45474: Icomplete exhibiting in recursive minibuffer when it =?UTF-8?Q?shouldn=E2=80=99t?= Date: Fri, 16 Apr 2021 16:55:56 +0000 Message-ID: <7dee3f423551aaf318cb@heytings.org> References: <3ed97a9c53e0a5d4fef8@heytings.org> <87fszrz21d.fsf@mail.linkov.net> <3ed97a9c530093aca93d@heytings.org> <7dee3f4235d331cab291@heytings.org> <87r1jatd34.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34952"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dario Gjorgjevski , 45474@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 16 19:50:31 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lXSbu-00090R-VQ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Apr 2021 19:50:31 +0200 Original-Received: from localhost ([::1]:52520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXSbt-0000kC-WC for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Apr 2021 13:50:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXRlC-0005Oo-BS for bug-gnu-emacs@gnu.org; Fri, 16 Apr 2021 12:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58271) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lXRlC-00055e-3i for bug-gnu-emacs@gnu.org; Fri, 16 Apr 2021 12:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lXRlC-0002Vg-0L for bug-gnu-emacs@gnu.org; Fri, 16 Apr 2021 12:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Apr 2021 16:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45474 X-GNU-PR-Package: emacs Original-Received: via spool by 45474-submit@debbugs.gnu.org id=B45474.16185921609639 (code B ref 45474); Fri, 16 Apr 2021 16:56:01 +0000 Original-Received: (at 45474) by debbugs.gnu.org; 16 Apr 2021 16:56:00 +0000 Original-Received: from localhost ([127.0.0.1]:41584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXRlA-0002VP-AG for submit@debbugs.gnu.org; Fri, 16 Apr 2021 12:56:00 -0400 Original-Received: from heytings.org ([95.142.160.155]:40660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXRl8-0002VE-FS for 45474@debbugs.gnu.org; Fri, 16 Apr 2021 12:55:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1618592156; bh=vAIjjq7wxgZaairOVSNxmEM4p+Y2tBHbyzEucGFKg88=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=j3+ujks84WuO6zMDpOG+7S0yTS4IslgMW7waY3c7LimyCgb/vWrp8nH5XAUVDm123 hu8E4Ajx12W+7flSqVjYr25xRPq8UIuJLzoRtfQRho2wYhQPi9uMbNNGUVwKdEsqF0 0wftf9FBTAV5Qcz7YQDUSgQEzEAJY9sRsVmSCj6FAKXMavAs3dfg5g/LvXOMqUaqKM uhOCeiQ3xyjzPn20+69wJJkCzayPZJrXsdpJaf/Pr46aEgv3ZEVrQtO2DbdMlndBc2 U+5NX27QzJsfPabULyXII+Cz7wMWxAZVAAYKk/P0aZw6uQ4JxLCw8F/37hYsWd7xs5 Ffc4NAet8aJEQ== In-Reply-To: <87r1jatd34.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204152 Archived-At: > > I wonder do you really intend to replace all hundreds of > read-from-minibuffer calls with read-from-minibuffer-simple? For > example, I use 'query-replace' a lot in the completion minibuffer, but > it's not fixed. > I don't know. Either we can fix them one by one as bug reports are filed, or we can fix them in one shot, possibly with a shorter name (say "input-from-minibuffer" or "get-from-minibuffer"). I don't see why it would be wrong to do that, or what it could break; the macro is as simple as possible. > > To be able to narrow the fix to icomplete.el only, it's possible to > check the value returned from (minibuffer-depth) before icomplete kicks > in, and disable icomplete completions when the value is greater than it > was when entered the first minibuffer initially, thus handling recursive > minibuffers that don't provide completions. > I'm not sure I understand what you mean by this, but AFAICS minibuffer-depth cannot be used to determine whether icomplete (or other completion backends) should be activated or not. If you do M-: C-x C-f, you want completions at minibuffer-depth = 1 and not at minibuffer-depth = 0; if you do C-x C-f M-:, you want completions at minibuffer-depth 0 and not at minibuffer-depth 1; if you do C-x C-f C-x 8 RET you want completions at minibuffer-depth 0 and at minibuffer-depth 1; if you do M-: C-x f you do not want completions at minibuffer-depth 0 nor at minibuffer-depth 1. > > Or maybe simply disable previous icomplete when recursive minibuffer > doesn't use completions. > And how would you detect whether a recursive minibuffer expects completions or not?