From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#72701: eglot crash when project-files-relative-names t Date: Sat, 24 Aug 2024 02:51:16 +0300 Message-ID: <7ddfb028-a182-486d-bb72-aeb26e0d1d4d@gutov.dev> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13914"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 72701@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , Ship Mints Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 24 01:52:47 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1she5F-0003RU-Em for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Aug 2024 01:52:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1she4o-0001Do-Jh; Fri, 23 Aug 2024 19:52:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1she4m-0001DQ-0k for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2024 19:52:16 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1she4k-0005U6-C9 for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2024 19:52:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=MQ1hCZsEBFRoZeNXy/STjXqez4ElktaYE4+khuDE/6A=; b=AB7STpalcNsE5jlRaXsstgacL4fdona+X7vuiw8z+eyEDDl59w0nFZ9tDF41t+7u/WHqzmyH6J4fza0IL48manUhtJ/WoLX1qi8zYjXKLclBBoQuEWWxyLKp3q4+HVG3GT/qpKCoAWvExpUvm/aGF1BY7mGR7M5YcTF9OXKsJUyB/EoslUwCCwKh8L1ifHPkJhl9DDeG6tcKDYn1PoxmV8rR625XbN6oZwz5X6XTSl401hfkrloA1O9mgQ/R35TokOgfIsQCDL0oM3Zo+blRDMXbbXzCfIJaxb5SefvBvee+UrtP9tG+7R/twzxF9UtYRX6EU1u3VL83wYoeTyzYwA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1she5V-00013y-OV for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2024 19:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Aug 2024 23:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72701 X-GNU-PR-Package: emacs Original-Received: via spool by 72701-submit@debbugs.gnu.org id=B72701.17244571364024 (code B ref 72701); Fri, 23 Aug 2024 23:53:01 +0000 Original-Received: (at 72701) by debbugs.gnu.org; 23 Aug 2024 23:52:16 +0000 Original-Received: from localhost ([127.0.0.1]:40220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1she4m-00012o-Da for submit@debbugs.gnu.org; Fri, 23 Aug 2024 19:52:16 -0400 Original-Received: from fout8-smtp.messagingengine.com ([103.168.172.151]:57423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1she4j-00012X-MK for 72701@debbugs.gnu.org; Fri, 23 Aug 2024 19:52:14 -0400 Original-Received: from phl-compute-06.internal (phl-compute-06.nyi.internal [10.202.2.46]) by mailfout.nyi.internal (Postfix) with ESMTP id 49BE013904D0; Fri, 23 Aug 2024 19:51:20 -0400 (EDT) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Fri, 23 Aug 2024 19:51:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1724457080; x=1724543480; bh=MQ1hCZsEBFRoZeNXy/STjXqez4ElktaYE4+khuDE/6A=; b= j+VOR9zuCPbiNRNBK3H01dK8zVWmoJnT5Gb2LyABbbyqx8MQiNvbGoHl9AsYr51q zVMqsZaCszwLk0oHySH9P+vxvvBmCRUxtHFUYRa2RLLaLWzI8UpL3pS9BcZZ5Fhl 5HVOH4kLwXiZr7vDU0oNqptS8qnUudfiHLQmvTjYeZ7LSckALHwCvr0cKeVzTPT8 IluHAkbomrOB9CZ6zwwjnkRmJMtNEHnQAwyJT/6HS0tJRUczlv+KucYy0F53hUSF cU6oHP5JOM+Ro/TEGozon3AFSc2XWjYkttUrQG1bGgpl7gH18AGYsD3p+jApMI1G J9+/1K6QcIjb+ZjphCnrsw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1724457080; x= 1724543480; bh=MQ1hCZsEBFRoZeNXy/STjXqez4ElktaYE4+khuDE/6A=; b=R FeT/Hi1Dx2JLhbw6l7/8H4njCmxv6sK2Tuo5NhFo8dWhNJKjPYG69VvDumXE71IN WgJqf1HIfLHFlxBCTsC0It0UaZgsiK7hP1qk7UHKcpMp0yuioGwvHkzoELhR5opb co7AtsrUBubAmjO7tYSnMU7jaLvo25ScmI1cw7xXc0MAaTU3jmWKfvHhI+Z3IYld hbnFHGF6Xh1/3e3QNPbb5wBdw7epXKlyoXAMB/hXhVv3Ooqg0IyG4lsFcjMf/Lvp YXyRmPNYZmdTy/nsYBR1DR8RVrPYhCxFvYwQfe8o+7dOEWlJJrvAVxa3AGnrfV0C VynyYrfL9jtofW8+z7/zg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddruddvfedgvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtvdej necuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdrug gvvheqnecuggftrfgrthhtvghrnhepgeelfeetkefghfdvhfdtgeevveevteetgeetveeg tedthefhudekteehffeukeeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghvpdhnsggprhgtphhtthho peefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehjohgrohhtrghvohhrrgesgh hmrghilhdrtghomhdprhgtphhtthhopehshhhiphhmihhnthhssehgmhgrihhlrdgtohhm pdhrtghpthhtohepjedvjedtudesuggvsggsuhhgshdrghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 23 Aug 2024 19:51:19 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290614 Archived-At: On 23/08/2024 18:08, João Távora wrote: > Eglot could be one of those features if there's a performance advantage. > But I doubt it, because server-supplied glob expressions may target the > full file name (indeed likely the truename). If the glob can match the full name, and it's hard to separate it into two matchers, I suppose there's not much that could be done. The binding is probably and an improvement for some off-in-the-future scenario where somebody has Emacs 30 installed, but upgrades project.el to some yet-unreleased version where the variable's default is flipped. > Maybe it's worth it nevertheless, > dunno. Anyway while let-binding p-f-r-names to nil in Eglot could work, I > don't think it's the right solution, especially since it probably triggers a > compilation warning in older Emacsen which don't have this. A (defvar ...) at the top of the function's body would help.