From: Dmitry Gutov <dgutov@yandex.ru>
To: 51215@debbugs.gnu.org
Subject: bug#51215: Add a navigation feature to vc and diff mode: diff-goto-line
Date: Tue, 19 Oct 2021 03:54:42 +0300 [thread overview]
Message-ID: <7dc92f6f-0e66-398a-cf2c-941d16026b66@yandex.ru> (raw)
In-Reply-To: <87k0iag5vr.fsf@mat.ucm.es>
Hi Uwe,
On 18.10.2021 10:16, Uwe Brauer wrote:
>> The most recent discussion regarding it can be found in bug#36526.
>
> I am not that used to that interface I jumped to
>
https://lists.gnu.org/archive/html/emacs-bug-tracker/2020-08/msg00633.html
You can read the discussion starting from
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=36526#53.
>> To sum up: the patch(es) have merit, and they're waiting for someone
>> to champion their inclusion: test them for bugs, compare the different
>> available implementations of the "skip to" functionality, and
>> generally examine how the new functionality affects the existing
>> workflows (e.g. whether it should be enabled on root diffs).
>
> Forgive me my ignorance (maybe because I am a mercurial user 😇)
> the documentation vc-root-diff talks about tree revision
>
> So if I understand that correctly this is for the case I want really
> consider the diff of the repository?
>
> That is the same effect as if: I change 3 files in the repository
and would run
> git diff
> or
> hg diff
> from the command line?
vc-root-diff, yes. 'C-x v D'.
> If that is the case I would say, disable the feature for that sort of
> diffs for the moment. The patch is more useful for
> one-file-basis.
> At least that is how I used it for a year.
OK, thanks for the feedback. But we should consider both changes in the
proposal, ideally. Not just the one you happened to have been using for
a period of time.
Would somebody else like to chime in?
> So what is the best strategy? How can I test the patch concerning
> bug#36526?
>
> The message talks about emacs 26, I am running a 2 month old
> git master emacs (still 28).
> So can that patch be tested in version I use?
That's a part of championing the change: try to see whether the patch
still applies. If not, maybe try updating it yourself.
prev parent reply other threads:[~2021-10-19 0:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 20:42 bug#51215: Add a navigation feature to vc and diff mode: diff-goto-line Uwe Brauer
2021-10-18 1:56 ` Dmitry Gutov
2021-10-18 7:16 ` Uwe Brauer
2021-10-18 7:24 ` Uwe Brauer
2021-10-19 0:49 ` Dmitry Gutov
2021-10-19 6:53 ` Juri Linkov
2021-10-19 23:18 ` Dmitry Gutov
2021-11-01 7:24 ` Uwe Brauer
2021-11-01 19:32 ` Juri Linkov
2021-11-01 8:41 ` Uwe Brauer
2022-09-10 5:13 ` Lars Ingebrigtsen
2022-09-10 5:14 ` Lars Ingebrigtsen
2022-09-10 7:15 ` Uwe Brauer
2022-09-10 23:21 ` Dmitry Gutov
2021-10-19 0:54 ` Dmitry Gutov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dc92f6f-0e66-398a-cf2c-941d16026b66@yandex.ru \
--to=dgutov@yandex.ru \
--cc=51215@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.