bug#66377: srecode-map-save-file :type doesn't allow nil

bug#66377: srecode-map-save-file :type doesn't allow nil

[Mauro Aranda]

The docstring of srecode-map-save-file says its value can be nil, but
its :type is just file.

bug#66377: srecode-map-save-file :type doesn't allow nil

[Mauro Aranda]

[-- Attachment #1: Type: text/plain, Size: 39 bytes --]

tags 66377 patch
quit


Patch attached.

[-- Attachment #2: 0001-Fix-a-defcustom-type.patch --]
[-- Type: text/x-patch, Size: 920 bytes --]

From 009542663d482a22427f621140bf365c861bfb81 Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Fri, 6 Oct 2023 17:02:37 -0300
Subject: [PATCH] Fix a defcustom :type

* lisp/cedet/srecode/map.el (srecode-map-save-file): Expand :type to
allow nil.  (Bug#66377)
---
 lisp/cedet/srecode/map.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/cedet/srecode/map.el b/lisp/cedet/srecode/map.el
index 125459d6eeb..004bb7adddb 100644
--- a/lisp/cedet/srecode/map.el
+++ b/lisp/cedet/srecode/map.el
@@ -49,7 +49,8 @@ srecode-map-save-file
   "The save location for SRecode's map file.
 If the save file is nil, then the MAP is not saved between sessions."
   :group 'srecode
-  :type 'file)
+  :type '(choice (const :tag "Don't save" nil)
+                 file))
 
 (defclass srecode-map (eieio-persistent)
   ((fileheaderline :initform ";; SRECODE TEMPLATE MAP")
-- 
2.34.1

bug#66377: srecode-map-save-file :type doesn't allow nil

[Eli Zaretskii]

> Date: Fri, 6 Oct 2023 17:11:07 -0300
> From: Mauro Aranda <maurooaranda@gmail.com>
> 
> tags 66377 patch
> quit
> 
> 
> Patch attached.

Thanks, installed on the emacs-29 branch, and closing the bug.