From: "Andreas Röhler" <andreas.roehler@easy-emacs.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 36664@debbugs.gnu.org
Subject: bug#36664: 27.0.50; definition of string-trim causes warning
Date: Mon, 15 Jul 2019 16:24:50 +0200 [thread overview]
Message-ID: <7cf99b15-3622-e5f5-2c0e-5b4c37274ca0@easy-emacs.de> (raw)
In-Reply-To: <m3o91v1o5v.fsf@gnus.org>
On 15.07.19 14:24, Lars Ingebrigtsen wrote:
> Andreas Röhler <andreas.roehler@easy-emacs.de> writes:
>
>> concerns subr-x.el
>>
>> When byte-compiling a file with def of trim-string inside, get a
>> warning: Lexical argument shadows the dynamic variable
>> string
> I'm not sure I follow. Do you mean if you have a function that calls
> string-trim (not define trim-string?) in a file, and you compile that
> file, you get that warning?
>
> If that's what you mean, I'm unable to reproduce the error.
>
Have that in python-mode.el --as older Emacsen might miss the function--:
;; subr-x.el might not exist yet
(unless (functionp 'string-trim)
(defsubst string-trim (string &optional trim-left trim-right)
"Trim STRING of leading and trailing strings matching TRIM-LEFT and
TRIM-RIGHT.
TRIM-LEFT and TRIM-RIGHT default to \"[ \\t\\n\\r]+\"."
(string-trim-left (string-trim-right string trim-right) trim-left))
[...]
next prev parent reply other threads:[~2019-07-15 14:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 12:20 bug#36664: 27.0.50; definition of string-trim causes warning Andreas Röhler
2019-07-15 12:24 ` Lars Ingebrigtsen
2019-07-15 14:24 ` Andreas Röhler [this message]
2019-07-15 14:33 ` Andreas Röhler
2019-07-15 15:26 ` Noam Postavsky
2019-07-15 15:16 ` Lars Ingebrigtsen
2019-07-15 15:18 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cf99b15-3622-e5f5-2c0e-5b4c37274ca0@easy-emacs.de \
--to=andreas.roehler@easy-emacs.de \
--cc=36664@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.