From: pjb@informatimago.com (Pascal J. Bourguignon)
To: help-gnu-emacs@gnu.org
Subject: Re: Setting the nth element of a list
Date: Fri, 05 Jun 2009 15:25:18 +0200 [thread overview]
Message-ID: <7ceityols1.fsf@pbourguignon.anevia.com> (raw)
In-Reply-To: 10cee0d4-43ff-4d2b-9a9b-735c8f83ffd4@x6g2000vbg.googlegroups.com
Nordlöw <per.nordlow@gmail.com> writes:
> On Jun 5, 3:06 pm, Nordlöw <per.nord...@gmail.com> wrote:
>> On Jun 5, 4:25 am, Barry Margolin <bar...@alum.mit.edu> wrote:
>>
>>
>>
>> > In article
>> > <8a7c4d36-195d-4517-827e-7fbeca7ae...@r34g2000vba.googlegroups.com>,
>>
>> > Nordlöw <per.nord...@gmail.com> wrote:
>> > > This simple example changes the second element in the list x:
>>
>> > > (setq x '(a nil c))
>> > > (setcar (cdr x 'b)
>>
>> > > How do I generalize this to a function that sets (changes) the nth
>> > > element of a list (for side effects only)?
>>
>> > > Thanks in advance,
>> > > Nordlöw
>>
>> > (require 'cl-macs)
>> > (setf (nth n x) 'b)
>>
>>
>> Okey, here is my solution:
>>
>> (defun setnthcar (n list x)
>> "Set N:th element of LIST to X for side effects only."
>> (setcar (nthcdr n list) x))
>>
>> Comments on that?
It's awful, since there's is already a more standard and more general
mechanism to do that: (setf (nth n x) 'b)
>> How do I accomplish the same with arrays? Using aref I guess. Here is
>> my mockup that doesn't yet do what I want:
>>
>> (defun setnthref (n array x)
>> "Set N:th element of ARRAY to X for side effects only."
>> (set (aref array n) x))
>>
>> Thanks in advance,
>> Nordlöw
>
> Okey I found a solution:
>
> (defun setnthref (n array x)
> "Set N:th element of ARRAY to X for side effects only."
> (setf (aref array n) x))
> ;; (equal (let ((l '[a b c])) (setnthref 1 l 'B) l) '[a B c])
>
> Is this the most efficient way? I see that setf() is quite
> complicated.
Setf is a macro that is quite complicated, but it generates the best
code to properly update a place.
(require 'cl)
(macroexpand '(setf (aref (aref (nth (incf a) list-of-arrays) (incf i)) n) 42))
-->
(let* ((#1=--cl-var-- (aref (nth (incf a) list-of-arrays) (incf i)))
(#2=--cl-var-- n))
(aset #1# #2# 42))
There's nothing more efficient to set an array than aset.
Once you've found the array to set...
So there's no need to define a setnthref for an array, since (setf
(aref a n) v) does the job better.
There's also no need to define a setnthcar for a list, since (setf
(nth l n) v) does the job better.
And if you don't know whether you have a list or a vector, there's no
need to define anything, since (setf (elt sequence n) v) works better.
(let (x)
(setf (elt (setf x (funcall (if (oddp (random 2))
(function list)
(function vector))
1 2 3))
1)
0)
x)
--> [1 0 3] or (1 0 3)
--
__Pascal Bourguignon__
next prev parent reply other threads:[~2009-06-05 13:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 21:08 Setting the nth element of a list Nordlöw
2009-06-04 22:06 ` Drew Adams
2009-06-04 22:35 ` Lennart Borgman
2009-06-05 2:25 ` Barry Margolin
2009-06-05 13:06 ` Nordlöw
2009-06-05 13:10 ` Nordlöw
2009-06-05 13:25 ` Pascal J. Bourguignon [this message]
2009-06-05 13:57 ` Nordlöw
2009-06-05 15:08 ` Pascal J. Bourguignon
2009-06-05 16:56 ` bigfaceworm
2009-06-06 6:01 ` Miles Bader
2009-06-05 20:51 ` Barry Margolin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ceityols1.fsf@pbourguignon.anevia.com \
--to=pjb@informatimago.com \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.