From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.help Subject: Re: Undo defalias Date: Fri, 03 Mar 2023 22:58:54 +0000 Message-ID: <7c6ec4cae3090ac235da@heytings.org> References: <878rgioa5f.fsf@telefonica.net> <87v8jhddul.fsf@telefonica.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21729"; mail-complaints-to="usenet@ciao.gmane.io" Cc: help-gnu-emacs@gnu.org To: Stefan Monnier Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 03 23:59:27 2023 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYEN5-0005VT-Iu for geh-help-gnu-emacs@m.gmane-mx.org; Fri, 03 Mar 2023 23:59:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYEMe-0000bW-8r; Fri, 03 Mar 2023 17:59:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYEMd-0000bN-0d for help-gnu-emacs@gnu.org; Fri, 03 Mar 2023 17:58:59 -0500 Original-Received: from heytings.org ([95.142.160.155]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYEMb-00077a-Dk for help-gnu-emacs@gnu.org; Fri, 03 Mar 2023 17:58:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1677884334; bh=+Z1RyljarhxKh5lF1/kv2zflWteUqYAfKG/U1j1hOKM=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=DVUEbGKbifqq1HTxDabDsiArrppxNpLSKWYpwiQM9JWBbRwx/bS92St/v89Sr7y2T +cVt/ZJC9uXqpAT3Ou9/NCUIMM/u4sHh1r0F4LYtp1LgBozzllVjy2yOYhy56l6a2d 85ecDt45OSBDqeLPI/p86sMpGLjid+zJ7BTY/r16Ygzgs4sefkJnQpCKAdyU7RhEJ5 tkdwH4ZfExwBJtzgmDw+Gl8YMO5MJkrLQqeX2OvpuQW91gCR1fLYskalhdNoUQn+d/ kjqrIzBCP24GE8kSpzXicAsnhw0MWkwDE5lYxnOajkb6lmmqdWn1dpyvXhjE06Vsqq 99wUdkrRZZtiQ== In-Reply-To: Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.help:142919 Archived-At: > > There's admittedly the possibility/risk that you hit `C-g` (or some > similar error occurred) right at the specific moment when `cl-letf` was > executing the second part of the `unwind-protect` (i.e. the one that > reset `message` to its previous definition). > > That's a known hole in our system. > Should we not inhibit-quit around the unwind-form of cl-letf to avoid this? Otherwise the promise of cl-letf ("On exit, either normally or because of a `throw' or error, the PLACEs are set back to their original values.") is not fulfilled. (And yes, I know that, even with inhibit-quit, it is still possible that a C-g would be processed just before we bind inhibit-quit.)