From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#73500: eglot: diagnostic location not always shown Date: Tue, 1 Oct 2024 23:39:24 +0300 Message-ID: <7c42a6a8-37e0-443c-b6ef-e1e321c1cb2b@gutov.dev> References: <1f4a7412-4bbf-4d08-ab41-e92d0398b541@gutov.dev> <1d06e46a-90c3-4683-9236-6550a57cd41d@fbengineering.ch> <8f4a5079-4f29-450b-97b0-fde41dfa052d@fbengineering.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8277"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: Federico Beffa , 73500-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 01 22:40:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1svjfX-0001xq-O2 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Oct 2024 22:40:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1svjfD-0006Lr-GZ; Tue, 01 Oct 2024 16:40:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svjf9-0006Jl-IZ for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2024 16:40:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1svjf9-0008W3-98 for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2024 16:40:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=4haVuMQvD41iSng6CUXZ2+ZU0sp4ksYh2J0qxWGIhgM=; b=snA28O4A3yD3OB9XcOOdMH8qqgprEsaLLydFwxVEvdYROsZRxd/pGRjtmcLH61+kmI+35YNp+IOXXqQ68LL33Q82HC9TkhLtqmEP7YJXtlsvicO96nRccpBGdB9zu16E/TAJ63kwZjPe34/rpEHP7V8JQoTVwo1epE1GsWlsICXMgRKrOh77jGX94k4RAlefpvpXYRr408IQ+7ifwKTaJGlB9qrMynn+NGnfSqH9SvCctGOax03aPW3YHmRMyrzbbsZfmvdM67ZYRDYUtOv9TIYmsK1RYWDomO2JbzPpXUYwfDHUaZd0Ffw4xBVqVPmyJRZy91/6yWFfVfRr6YMTcw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1svjf8-0001c9-NG for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2024 16:40:02 -0400 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Oct 2024 20:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 73500 X-GNU-PR-Package: emacs Mail-Followup-To: 73500@debbugs.gnu.org, dmitry@gutov.dev, federico.beffa@fbengineering.ch Original-Received: via spool by 73500-done@debbugs.gnu.org id=D73500.17278151746159 (code D ref 73500); Tue, 01 Oct 2024 20:40:02 +0000 Original-Received: (at 73500-done) by debbugs.gnu.org; 1 Oct 2024 20:39:34 +0000 Original-Received: from localhost ([127.0.0.1]:53559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svjeg-0001bH-AP for submit@debbugs.gnu.org; Tue, 01 Oct 2024 16:39:34 -0400 Original-Received: from fhigh-a6-smtp.messagingengine.com ([103.168.172.157]:44025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svjee-0001b7-M1 for 73500-done@debbugs.gnu.org; Tue, 01 Oct 2024 16:39:33 -0400 Original-Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfhigh.phl.internal (Postfix) with ESMTP id ADB031140B26; Tue, 1 Oct 2024 16:39:27 -0400 (EDT) Original-Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-10.internal (MEProxy); Tue, 01 Oct 2024 16:39:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1727815167; x=1727901567; bh=4haVuMQvD41iSng6CUXZ2+ZU0sp4ksYh2J0qxWGIhgM=; b= S2fg7QjdFHdJ4eGI9T6s6zD14rhwEPYrslHSTX5QGeqg6QDkA68Gvt93nUtYZEYh GB7miMz2l3Ij52aYEYQz94CIHEAIZkBIM4sRSZ7nQrIvZB5VU2OHPXv43238EC5D FrJjwlGHvLPhQ7w8CW36ZiTmVPW14bNRaSc5e1LwDSgP9tjnjpTqJwTnDtfrZhhK 1k7HyKIa9AIPLe7EBDPykCZQ+aH0NBK22s9PKCuRENB0uEbLQZiy6TwBDa7X/itN cp6n8vdkJXGvph8qtXV/LjsYRf22pH+RxwUKn77KclseDwkCbDkuDgZXggWb1zyb JFw5diXPQHXWMbXCgmgOUQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1727815167; x= 1727901567; bh=4haVuMQvD41iSng6CUXZ2+ZU0sp4ksYh2J0qxWGIhgM=; b=W VtlqTOzNL8BpUSs+69veMZPQf+lA2gAIX+hTNavvIatuDtc1n707CDoHXdoLswp4 s0R16laX+0fZLpVwhekcyil/ld9N2QMFAj1swy4j+nCBBy10H5Mc4FzJX5uAhmvA lvqxl74P6zsiH0+ze2S0haF+SBRgR5OLGGl7U/wTEuiYhtxI8/0+dojfnK7AYb5a F7MwWQ7unY6AyDZxyPym5tsr+iBNTdCCltVqjq+aI81s4ZgLjuxV4rbIV7XoTd6L 6B/LnqeRSJ39CrB8/Y5wUmGRJzjmGdotsIz7kNhJL3ZdEvQtOeXlaZmSwxtOvLgm 5wfwTB2mB+gsVGuiciUng== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvddujedgudeglecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenogfuuhhsphgvtghtffhomhgrihhnucdlgeelmdenucfjughr pefkffggfgfuvfhfhfgjtgfgsehtkeertddtvdejnecuhfhrohhmpeffmhhithhrhicuif huthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrthhtvghrnhep geeuudetgeehtdeuffdugfdtfeettdffhefhteejgfeludegvdelveeilefgudegnecuff homhgrihhnpehgnhhurdhorhhgpdhgihhthhhusgdrihhonecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvg hvpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehf vgguvghrihgtohdrsggvfhhfrgesfhgsvghnghhinhgvvghrihhnghdrtghhpdhrtghpth htohepjeefhedttddqughonhgvseguvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 1 Oct 2024 16:39:25 -0400 (EDT) Content-Language: en-US In-Reply-To: <8f4a5079-4f29-450b-97b0-fde41dfa052d@fbengineering.ch> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292795 Archived-At: On 01/10/2024 23:18, Federico Beffa wrote: > On 01/10/2024 21:48, Dmitry Gutov wrote: >> That one is using the face eglot-diagnostic-tag-unnecessary-face, >> which you can customize to add an underline or any other decorations. >> >> It was added in commit 0f44d338f17bd4, see the description here >> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=0f44d338f17bd4 >> >> The choice of using 'shadow' is explained with a reference to the >> protocol, which says: >> >> /** >>  * Unused or unnecessary code. >>  * >>  * Clients are allowed to render diagnostics with this tag faded out >>  * instead of having an error squiggle. >>  */ >> >> https://microsoft.github.io/language-server-protocol/specifications/ >> lsp/3.17/specification/#diagnosticTag >> > > OK, I see, the shadow is so similar the normal font that, before you > mentioned it, it was unnoticeable to me. But if it's customizable, > that's great. Yep. I suggest customizing 'shadow' itself then, if it's not noticeable enough on your system/theme/etc. >> > Here a screenshot >> >> Same look on my machine. >> >> Should we remove the exclamation point instead, to avoid the semantic >> conflict? I'm not sure, probably not. > > Is the exclamation mark used with all warnings? If yes, I'd keep it. > Even if the warning has a tag equal to 1, it's still a warning. It is. Sure. > Thanks for your help! No problem! Guess we're finished here, so I'm closing the report.