From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Charl P. Botha" Newsgroups: gmane.emacs.bugs Subject: bug#59945: [PATCH] Fix empty pairs in js tree-sitter imenu alist Date: Tue, 13 Dec 2022 09:48:02 +0200 Message-ID: <7c331556-090e-4e44-a337-6f506e81d811@app.fastmail.com> References: <2CD18C33-060B-4BC1-860E-1EB097EA7F0C@gmail.com> Mime-Version: 1.0 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37377"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Cyrus-JMAP/3.7.0-alpha0-1115-g8b801eadce-fm-20221102.001-g8b801ead Cc: Eli Zaretskii , 59945@debbugs.gnu.org To: "Yuan Fu" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 13 09:14:05 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p50QL-0009OV-Uz for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Dec 2022 09:14:03 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p50Hi-0007ZI-DR; Tue, 13 Dec 2022 03:05:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p50Fk-0006RT-BV for bug-gnu-emacs@gnu.org; Tue, 13 Dec 2022 03:03:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p50Fk-0000cx-1b for bug-gnu-emacs@gnu.org; Tue, 13 Dec 2022 03:03:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p50Fj-0001Mg-Sy for bug-gnu-emacs@gnu.org; Tue, 13 Dec 2022 03:03:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Charl P. Botha" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Dec 2022 08:03:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59945 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59945-submit@debbugs.gnu.org id=B59945.16709185795213 (code B ref 59945); Tue, 13 Dec 2022 08:03:03 +0000 Original-Received: (at 59945) by debbugs.gnu.org; 13 Dec 2022 08:02:59 +0000 Original-Received: from localhost ([127.0.0.1]:58784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p50Fe-0001Lx-Bn for submit@debbugs.gnu.org; Tue, 13 Dec 2022 03:02:58 -0500 Original-Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:53011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p501d-0001D0-I2 for 59945@debbugs.gnu.org; Tue, 13 Dec 2022 02:48:30 -0500 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 8C4233200950; Tue, 13 Dec 2022 02:48:23 -0500 (EST) Original-Received: from imap44 ([10.202.2.94]) by compute2.internal (MEProxy); Tue, 13 Dec 2022 02:48:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vxlabs.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1670917703; x= 1671004103; bh=ykfvn6VB8fThATsQ2VblLUYwKEDCg+Ean2loB4/vXlk=; b=G WDPi8+tjb/gR+KxmIaJ2ioQrIw/LEKRBg/7IER5/oYYbk+TQ6VZyvWpSmBWoxxq9 3o+uv3ZrFC20Dt23ADjF7YvwiXqqVH5Hu6hhChEOdtGenBjG+TZDI7xZ0fSiaBh7 cTkmA+C41Hf3X/CnAzpZYQq0m0YjlYbhyAZBBBDpPCi9EljdiZnZUT6HTkyP82wx fYqm3Ur7Fqysz5Yu+8b85eg2gvXxPFFVp9sijwf2PuqMpf4ypHbdBkftQvXEbsII 90a/abDQyRfidQVhQOv2qnKufy9eDPAnc/h5koFn5kp3nSDY6SeImE5ka2vx68kf 0VyFPAimEEgKtA1cJ0qRQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1670917703; x= 1671004103; bh=ykfvn6VB8fThATsQ2VblLUYwKEDCg+Ean2loB4/vXlk=; b=C 9L2Gk6PloyUiDNgcTKzrsoKmU9UkQlb3AHcKSRRb7pr1jXX5MfKB0O45H8Y2PaOf F9AEDu4k+kmij0ul2ZrnmCkLRKREO7pKoMq+HpgOxASs0jm+hZsUi9AI5Ms72say RyQrsLemkgu+KcBteGeQxpUnJ0oz2Z9wMKtaGTQSCWkCFB/7h1kd8nTFjngtAMp/ y5h3xB02oabT2ey5nsOCTp9lNrO9RFFyqSfVW7F7m6JmvhWDEdBnBEtAcMc0cAlp ssIzPPEAbLI7rhQ5CUwkNcM4QG1YVLk0wYS+5a2d2XEbduaW8yEDf9pm7ayeJsDL lBIoOOlUcZJCSQ7Yst0yw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdelgdduudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdev hhgrrhhlucfrrdcuuehothhhrgdfuceotghpsghothhhrgesvhiglhgrsghsrdgtohhmqe enucggtffrrghtthgvrhhnpedtveeiledvhfehjeekueeiteefvedtleekteelvdegledu udegkeffudehieekveenucffohhmrghinhepghhithhhuhgsrdgtohhmpdhmihhtrdgvug hupdhkvgihsggrshgvrdhiohenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpegtphgsohhthhgrsehvgihlrggsshdrtghomh X-ME-Proxy: Feedback-ID: i502842e6:Fastmail Original-Received: by mailuser.nyi.internal (Postfix, from userid 501) id CBB2536A0073; Tue, 13 Dec 2022 02:48:22 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: <2CD18C33-060B-4BC1-860E-1EB097EA7F0C@gmail.com> X-Mailman-Approved-At: Tue, 13 Dec 2022 03:02:53 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250812 Archived-At: Dear Yuan Fu, dear Eli, On Tue, Dec 13, 2022, at 00:28, Yuan Fu wrote: > "Charl P. Botha" writes: > >> The current js--treesit-imenu, used by the JavaScript, TypeScript and >> TSX tree-sitter modes, would return empty pairs in the imenu alist if >> there were none of that type of symbol. >> >> This would break both the built in imenu and also packages like >> consult-imenu. >> >> See https://github.com/minad/consult/issues/697 for the discussion >> there. > > Thank you very much! Sorry for the inconvenience it caused. Have you > signed the copyright assignment? I=E2=80=99m asking because this chang= e is on > the verge of 15 lines. Eli, WDYT? Emacs is (and always has been) a positive force in my life, thank you fo= r all the energy that you pour into it! I have not yet signed the copyright assignment, I would gladly do so. Hopefully we can do this digitally? I live in South Africa, but I'm a Du= tch citizen, in case that matters. I also have a PGP key [1] that's fair= ly well connected and can be verified on keybase (FWIW) [2] Kind regards, Charl [1] http://pgp.mit.edu:11371/pks/lookup?op=3Dget&search=3D0x384435C7E77A= 4564 [2] https://keybase.io/cpbotha