From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#57129: 29.0.50; Improve behavior of conditionals in Eshell Date: Sat, 13 Aug 2022 11:56:20 -0700 Message-ID: <7c04a92b-85f4-41c3-917b-4716cca2b9d6@gmail.com> References: <8fb3461d-b7eb-23c4-2736-cdd6dfeb1aa0@gmail.com> <87mtc9o5af.fsf@gnus.org> <83h72gmxtq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19589"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 57129@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 13 20:58:57 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oMwLY-0004zE-Rg for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Aug 2022 20:58:56 +0200 Original-Received: from localhost ([::1]:60334 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oMwLX-00009N-Qj for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Aug 2022 14:58:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oMwJi-0006p4-Qx for bug-gnu-emacs@gnu.org; Sat, 13 Aug 2022 14:57:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45352) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oMwJi-0001Zf-GZ for bug-gnu-emacs@gnu.org; Sat, 13 Aug 2022 14:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oMwJi-0000t7-Ce for bug-gnu-emacs@gnu.org; Sat, 13 Aug 2022 14:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Aug 2022 18:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57129 X-GNU-PR-Package: emacs Original-Received: via spool by 57129-submit@debbugs.gnu.org id=B57129.16604169913378 (code B ref 57129); Sat, 13 Aug 2022 18:57:02 +0000 Original-Received: (at 57129) by debbugs.gnu.org; 13 Aug 2022 18:56:31 +0000 Original-Received: from localhost ([127.0.0.1]:35101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMwJD-0000sQ-Dw for submit@debbugs.gnu.org; Sat, 13 Aug 2022 14:56:31 -0400 Original-Received: from mail-pl1-f180.google.com ([209.85.214.180]:47005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMwJB-0000sC-Dq for 57129@debbugs.gnu.org; Sat, 13 Aug 2022 14:56:29 -0400 Original-Received: by mail-pl1-f180.google.com with SMTP id jm11so1093509plb.13 for <57129@debbugs.gnu.org>; Sat, 13 Aug 2022 11:56:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:cc:to:subject:from:to:cc; bh=nd4O7bcDJhEIRyTVDAR7SqGynpKMwDeux89I3OiKZas=; b=U8okBEMFvngnhnBHUOWlOrxaQaJ41IuNhskKhPIvXPQxM6AQ/BI7n8d2OqUCQOnYc+ 5AEX8LfcFJPLbxx4ZkllxCKocsKMN5Bqh/SK9sOWq7FJ7/FO7VdG4iLdCnKDFBMwFcaH knJqmpEttqcMwt1thkKG9qKY/y1kyTZjR84K6Ms2M0gfidoXhSZfqx9Sb60smAY9i6u3 0lRuxMksh50J2T2/bbhy6zx88Eg8VZv/0e9nHSXERd8MMhg6snhX2xqXRIrBBwKCTXM8 Q+iiJC8FHiXpq/sW8Yus6Eq3Cb49B6SjgfAYm6UL/couGFtiyQ6rK28xdpsxez4W+EMh 5YEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:cc:to:subject:x-gm-message-state :from:to:cc; bh=nd4O7bcDJhEIRyTVDAR7SqGynpKMwDeux89I3OiKZas=; b=13ZQo6RGn6Qe3tpoN5p1P3qihtSy3Gy28qmesaejIYHXwcfXtGQOrCO8PXofRHC3Ob 2NFax8TJf4no8aOTD80Q/0YhJyaki7IMdav3csnUkD+4s/kWVbf3FPkpzDeZMKWdaKxX E04nlK5QINleYprBSbXrHEtSp/tFkjQIPY4h+sbw7Khz0iPMqf0UCO7EsZs026bQxDIH WJJWB+jdw1Uxdcs6upsH3IuXJeLMMtMLnt0Qq8idocMZ50l2j8M79qGWJSrzLdl0t6xX +NacpXnKYqxrdqj5wJrPF08Ie/6ZmOBuZ85yTNusYZL2Ombs9Xu8SfEFm8sxGFwBDOdN 2paA== X-Gm-Message-State: ACgBeo1LuB8BgS3XyPxF+lOdrmu/FEg4d6Fqqr6NMLFJPSJ15tzTvO3O 6jEwJLnBfgRf5pzyGUp34yTl1OFx3wU= X-Google-Smtp-Source: AA6agR7ec/dS7nGDjOzB9aN1M6V5hLbzWbBaWcjwaP7pRLPznYzWk1k7yQ2I7hywdrosKL8B2xpiQw== X-Received: by 2002:a17:902:cf0e:b0:172:60b7:777c with SMTP id i14-20020a170902cf0e00b0017260b7777cmr2266076plg.132.1660416983328; Sat, 13 Aug 2022 11:56:23 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id fv20-20020a17090b0e9400b001f2fbf2c42esm1934541pjb.26.2022.08.13.11.56.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Aug 2022 11:56:22 -0700 (PDT) In-Reply-To: <83h72gmxtq.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239584 Archived-At: On 8/13/2022 12:01 AM, Eli Zaretskii wrote: > One of the tests in esh-var-tests.el failed on MS-Windows; I fixed it, > although I'm not sure it's a correct fix, because the Eshell manual > seems to say that a built-in implementation of a command should be > preferred by default? Sorry about that. I think that's the right fix for that case. Maybe it would make sense to set 'eshell-prefer-lisp-functions' to t for most of the Eshell tests to improve reproducibility on various platforms; tests that want an external command can just put a "*" in front of the command name. > One of the tests in eshell-tests.el also fails on MS-Windows, but I > have no idea how to fix it, nor even what are the details of the > test. Are the 'echo' commands in that test supposed to be external > shell commands or internal Eshell commands? If the former, it could > be a problem on MS-Windows. The echo commands should be internal Eshell commands (since there's an 'eshell/echo' Lisp function, that one should always be preferred by Eshell). I'm surprised that test fails on MS Windows, since it *should* be testing internal Eshell logic that's not platform-specific. Based on the failure, it looks like one of the following commands is returning the wrong value: echo {echo $eshell-in-pipeline-p | echo} | *cat echo ${echo $eshell-in-pipeline-p | echo} | *cat *cat $ | *cat All of these should return 'first'. That test is just checking that, when you're in a subcommand ({...}, ${...}, or $<...>), the value of 'eshell-in-pipeline-p' shouldn't be influenced by the pipeline in the "super-command". Some built-in Eshell commands consult 'eshell-in-pipeline-p', and if it had the wrong value, they might do the wrong thing. If nothing else, it would probably be helpful to set up ERT explainers so that the error messages are easier to understand. As it is now, they're not very explanatory.