From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#15698: Show commit revision Date: Sun, 24 Jan 2021 02:10:25 +0200 Message-ID: <7bd7bb49-bcd9-7246-10cc-8bd83b9e3890@yandex.ru> References: <87h7n7s31p.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3799"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: 15698@debbugs.gnu.org To: Lars Ingebrigtsen , Paul Pogonyshev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 24 01:11:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3Szy-0000sS-H7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Jan 2021 01:11:22 +0100 Original-Received: from localhost ([::1]:46228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3Szx-0002Ph-Bm for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Jan 2021 19:11:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3Sze-0002PX-A0 for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2021 19:11:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52319) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l3Sze-0007vb-1t for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2021 19:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l3Szd-0001Vp-Qf for bug-gnu-emacs@gnu.org; Sat, 23 Jan 2021 19:11:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Jan 2021 00:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15698 X-GNU-PR-Package: emacs Original-Received: via spool by 15698-submit@debbugs.gnu.org id=B15698.16114470365779 (code B ref 15698); Sun, 24 Jan 2021 00:11:01 +0000 Original-Received: (at 15698) by debbugs.gnu.org; 24 Jan 2021 00:10:36 +0000 Original-Received: from localhost ([127.0.0.1]:35632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3SzE-0001V9-3U for submit@debbugs.gnu.org; Sat, 23 Jan 2021 19:10:36 -0500 Original-Received: from mail-ej1-f43.google.com ([209.85.218.43]:45045) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l3SzB-0001Uv-W4 for 15698@debbugs.gnu.org; Sat, 23 Jan 2021 19:10:34 -0500 Original-Received: by mail-ej1-f43.google.com with SMTP id w1so12844061ejf.11 for <15698@debbugs.gnu.org>; Sat, 23 Jan 2021 16:10:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VP8Pki2wIAibzjE8i+ohv40gn6nx9/DgTXgyBWlIAVk=; b=ahTW+kCjeWSycA+AdRvKMgfYTXk9995XTcMqqkKSu9sg6tBEeZ8ZFYHOVx2bnR9MZm zbOEpnlo+INoIk8xzglL63xQa0sgRlratOkfukmIRZ6eXMwvFmhUTrkSIq0cHSXpEdxV Vrgra5aEPv6gbHPiP1aXBqaHpkiljA3o5XBd+xDST6htNt83NFyvk95juqxxN4pnjCca AwoatcPPeuq9q9lfKc4TDi+gbAtW9KipE6akpQ1CS+wO8XBJipEM19TelHTWrGHsOc2j 3K3ZkuviWtrLR7W1axe2W1BcquD2W5WvaiZ0jpncLnuEx7yml36VZER5XyaB2x0YVVux UGXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VP8Pki2wIAibzjE8i+ohv40gn6nx9/DgTXgyBWlIAVk=; b=G4iKMxVFtchQUyswx03ZyTtPM0cZOThHON5O0QMzzF41hRhGzg9d5nXno8SXrssz9s WtOPA7IHxvkd+qMyi3M+DKLOXQpdAfpm2Zz0sRcZEdDm8PnPUXPmKorRCtGWjB2KIVM0 4JOvCPa7iGxRlHPYLg38O8nfyOxOjCXZ7cphcPQZDMiH6BB3QkfSjzAspIW6DR1FnzyG nbPt67eNhpLQQA8y6VtyimlwTZL4NcKuPf1LKmhWKxcMIBb/rQmMi4okWQdeUKeBmPgR TMlfTxzXpCr4f3qDPRWL0QmGkcnG0VKFlinevCLNGLOYoEipcEWYWHGMTB8XOUGinoif ceyg== X-Gm-Message-State: AOAM532Yw4NGZLYkcADBdOd0vuGTdKv4JDf1ncHOp3ARplhR2HX7yNNi UtqM0N61w2McX5mOlmvlxbxzQOWPlwg= X-Google-Smtp-Source: ABdhPJwuPbM8Mdcc9uY9zpYnVmVp0uS8YuSX0rdelpovgOGvoIijqJKU7ywTEKBR0HW3G9TJZjDAxQ== X-Received: by 2002:a17:906:c5b:: with SMTP id t27mr2032432ejf.129.1611447027960; Sat, 23 Jan 2021 16:10:27 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id f9sm7874625edm.6.2021.01.23.16.10.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Jan 2021 16:10:27 -0800 (PST) In-Reply-To: <87h7n7s31p.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198488 Archived-At: On 24.01.2021 00:26, Lars Ingebrigtsen wrote: >> Minor feature request. When committing from VC directory buffer, it >> would be useful to see the exact revision number, because I usually >> need it for reporting. Currently my workflow is to commit => >> immediately open log buffer to see revision number. >> >> I'd suggest amending message "Checking in /home/user/dir...done" message as >> something like "Checking in /home/user/dir...done as revision 1234". > (I'm going through old bug reports that unfortunately got no response at > the time.) > > I'm not sure this would be generally useful -- particularly with VCs > like git, where the revision string is really long, which means that you > can't just type it from memory. That sounds like a bit of a pain to implement, to be honest. If we wanted to show the revision at the end, and implement it in some backend-agnostic way, we'd have to add some new action, or an argument to vc-working-revision (like short-revision)... and implement that for some backends. Further, while I also often use the resulting revision string, it really depends on whether I end up having to rebase before pushing, and that changes the revision. >> Alternatively, just have VC directory buffer always show the last >> revision (but this can be problematic/confusing for SVN at least, >> e.g. my last commit was 7892, yet 'svn info' shows 7871). > This could perhaps be useful, though? That is, having a line in the > -dir-extra-headers section saying what the current revision is? I've > added Dmitry to the CCs; perhaps he's got an opinion here. This should be relatively easy to do, adding some text in each individual backends' function vc-XYZ-dir-extra-headers. Less indirection, too. vc-git could show the short revision after the branch name, for example. vc-svn could just add a new "extra header", I guess. Looks like its current list is much shorter. I don't know what's the deal with SVN's revisions, though.