all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Lars Ingebrigtsen <larsi@gnus.org>,
	Paul Pogonyshev <pogonyshev@gmail.com>
Cc: 15698@debbugs.gnu.org
Subject: bug#15698: Show commit revision
Date: Sun, 24 Jan 2021 02:10:25 +0200	[thread overview]
Message-ID: <7bd7bb49-bcd9-7246-10cc-8bd83b9e3890@yandex.ru> (raw)
In-Reply-To: <87h7n7s31p.fsf@gnus.org>

On 24.01.2021 00:26, Lars Ingebrigtsen wrote:
>> Minor feature request. When committing from VC directory buffer, it
>> would be useful to see the exact revision number, because I usually
>> need it for reporting.  Currently my workflow is to commit =>
>> immediately open log buffer to see revision number.
>>
>> I'd suggest amending message "Checking in /home/user/dir...done" message as
>> something like "Checking in /home/user/dir...done as revision 1234".
> (I'm going through old bug reports that unfortunately got no response at
> the time.)
> 
> I'm not sure this would be generally useful -- particularly with VCs
> like git, where the revision string is really long, which means that you
> can't just type it from memory.

That sounds like a bit of a pain to implement, to be honest. If we 
wanted to show the revision at the end, and implement it in some 
backend-agnostic way, we'd have to add some new action, or an argument 
to vc-working-revision (like short-revision)... and implement that for 
some backends.

Further, while I also often use the resulting revision string, it really 
depends on whether I end up having to rebase before pushing, and that 
changes the revision.

>> Alternatively, just have VC directory buffer always show the last
>> revision (but this can be problematic/confusing for SVN at least,
>> e.g. my last commit was 7892, yet 'svn info' shows 7871).
> This could perhaps be useful, though?  That is, having a line in the
> -dir-extra-headers section saying what the current revision is?  I've
> added Dmitry to the CCs; perhaps he's got an opinion here.

This should be relatively easy to do, adding some text in each 
individual backends' function vc-XYZ-dir-extra-headers. Less 
indirection, too.

vc-git could show the short revision after the branch name, for example.

vc-svn could just add a new "extra header", I guess. Looks like its 
current list is much shorter.

I don't know what's the deal with SVN's revisions, though.





  reply	other threads:[~2021-01-24  0:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-24  8:18 bug#15698: Show commit revision Paul Pogonyshev
2021-01-23 22:26 ` Lars Ingebrigtsen
2021-01-24  0:10   ` Dmitry Gutov [this message]
2021-01-25 23:56     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7bd7bb49-bcd9-7246-10cc-8bd83b9e3890@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=15698@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=pogonyshev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.