From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 0e56883: Move undocumented time-stamp formats closer to format-time-string Date: Thu, 10 Oct 2019 00:17:54 -0700 Organization: UCLA Computer Science Department Message-ID: <7b61e0a3-fbad-0bd2-87b1-dca5c29c19fe@cs.ucla.edu> References: <20191001032457.2675.32057@vcs0.savannah.gnu.org> <20191001032458.E3A4D207F5@vcs0.savannah.gnu.org> <83woddu4yp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------E4103A16DCC7A451326CD365" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="27787"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: stepheng+savannah@gildea.com, emacs-devel@gnu.org To: Eli Zaretskii , Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 10 09:18:15 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iISiF-000778-Ci for ged-emacs-devel@m.gmane.org; Thu, 10 Oct 2019 09:18:15 +0200 Original-Received: from localhost ([::1]:34618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iISiE-0005uS-7r for ged-emacs-devel@m.gmane.org; Thu, 10 Oct 2019 03:18:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49925) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iISi7-0005uB-TO for emacs-devel@gnu.org; Thu, 10 Oct 2019 03:18:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iISi6-0005HB-LZ for emacs-devel@gnu.org; Thu, 10 Oct 2019 03:18:07 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:46248) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIShz-0005CX-TS; Thu, 10 Oct 2019 03:18:01 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 3A6641604E9; Thu, 10 Oct 2019 00:17:56 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id yrbY391pnEZt; Thu, 10 Oct 2019 00:17:55 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 17B331604FA; Thu, 10 Oct 2019 00:17:55 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id EW1mX95mwu-f; Thu, 10 Oct 2019 00:17:54 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id E02F01604E9; Thu, 10 Oct 2019 00:17:54 -0700 (PDT) In-Reply-To: <83woddu4yp.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240814 Archived-At: This is a multi-part message in MIME format. --------------E4103A16DCC7A451326CD365 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 10/9/19 11:52 AM, Eli Zaretskii wrote: > Do you understand why macOS returns UTC where GMT is expected? Yes, it's what the low-level gmtime_r function returns in its struct tm. This aspect of gmtime_r is not standardized, and some implementations return "GMT", some "UTC", and I vaguely recall seeing other abbreviations. I installed the attached patch, which should fix the problem though I've tested it only on GNU/Linux. --------------E4103A16DCC7A451326CD365 Content-Type: text/x-patch; name="0001-Port-time-stamp-test-time-zone-to-macOS.patch" Content-Disposition: attachment; filename="0001-Port-time-stamp-test-time-zone-to-macOS.patch" Content-Transfer-Encoding: quoted-printable >From a05609991f68de5825b37a9ed6b1e5d2cccbd2ae Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 10 Oct 2019 00:15:24 -0700 Subject: [PATCH] Port time-stamp-test-time-zone to macOS MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit Problem reported by Stefan Kangas in: https://lists.gnu.org/r/emacs-devel/2019-10/msg00360.html * test/lisp/time-stamp-tests.el (time-stamp-test-time-zone): Don=E2=80=99t assume (format-time-string "%Z" 0 t) returns "GMT". --- test/lisp/time-stamp-tests.el | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/test/lisp/time-stamp-tests.el b/test/lisp/time-stamp-tests.e= l index ace5e58e36..37822f6e29 100644 --- a/test/lisp/time-stamp-tests.el +++ b/test/lisp/time-stamp-tests.el @@ -298,12 +298,14 @@ time-stamp-test-day-number-in-week (ert-deftest time-stamp-test-time-zone () "Test time-stamp formats for time zone." (with-time-stamp-test-env - ;; implemented and documented since 1995 - (should (equal (time-stamp-string "%Z" ref-time) "GMT")) - ;; documented 1995-2019 - (should (equal (time-stamp-string "%z" ref-time) "gmt")) - ;; implemented since 1997, documented since 2019 - (should (equal (time-stamp-string "%#Z" ref-time) "gmt")))) + (let ((UTC-abbr (format-time-string "%Z" ref-time t)) + (utc-abbr (format-time-string "%#Z" ref-time t))) + ;; implemented and documented since 1995 + (should (equal (time-stamp-string "%Z" ref-time) UTC-abbr)) + ;; documented 1995-2019 + (should (equal (time-stamp-string "%z" ref-time) utc-abbr)) + ;; implemented since 1997, documented since 2019 + (should (equal (time-stamp-string "%#Z" ref-time) utc-abbr))))) =20 (ert-deftest time-stamp-test-non-date-conversions () "Test time-stamp formats for non-date items." --=20 2.17.1 --------------E4103A16DCC7A451326CD365--