From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Deniz Dogan Newsgroups: gmane.emacs.devel Subject: js.el: Correct highlighting of JS "dictionary keys"? Date: Fri, 19 Feb 2010 14:15:38 +0100 Message-ID: <7b501d5c1002190515v6307b7a4v9163ed42696584f7@mail.gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: ger.gmane.org 1266585376 25199 80.91.229.12 (19 Feb 2010 13:16:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 19 Feb 2010 13:16:16 +0000 (UTC) To: Emacs-Devel devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 19 14:16:14 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NiSiJ-0002dg-56 for ged-emacs-devel@m.gmane.org; Fri, 19 Feb 2010 14:16:11 +0100 Original-Received: from localhost ([127.0.0.1]:36264 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NiSiI-0003ET-HW for ged-emacs-devel@m.gmane.org; Fri, 19 Feb 2010 08:16:10 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NiSiC-0003E3-DH for emacs-devel@gnu.org; Fri, 19 Feb 2010 08:16:04 -0500 Original-Received: from [140.186.70.92] (port=46151 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NiSiA-0003Du-IM for emacs-devel@gnu.org; Fri, 19 Feb 2010 08:16:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NiSi8-0005Ll-5J for emacs-devel@gnu.org; Fri, 19 Feb 2010 08:16:02 -0500 Original-Received: from mail-ew0-f228.google.com ([209.85.219.228]:50672) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NiSi7-0005LQ-Kg for emacs-devel@gnu.org; Fri, 19 Feb 2010 08:16:00 -0500 Original-Received: by ewy28 with SMTP id 28so65198ewy.8 for ; Fri, 19 Feb 2010 05:15:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:message-id :subject:to:content-type; bh=lo4M1Glok+u4tk+iTCnIx2Q+s9e05xVT7IvuSDgw0Nc=; b=u+xbzhIZhQjo2leYw77t2I3ca4IM/pKkmGwIkTn688zEmcgJTF7topZ0Csb4D8+iYU Zm5aZSCHqAA/G4b3tAd+3VVPxa3p2toehGOazn6Av4cVrme6AV0fbFo26mp1ILzEELi6 2NBkZMH3PjllQv8PAQ0fpqEPUBPs+r0Tl8I7E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=u6bxiWwMkLeay3Jp9XaLUAzmN0mXiXc9XcNUnn0/PKCNvFYW2oL/71jZhR0jBvutc+ 12JX8AQHwlooHqwkMW3KAGABbMP3xxz+vO8JkXY78/XTQxV5iSd3xE2gr7jzRPdNFbJz Yq/BlgSW4tWHqW5fQQ59kbeXQJbfH2ZDbqB7g= Original-Received: by 10.213.103.133 with SMTP id k5mr5351480ebo.76.1266585358121; Fri, 19 Feb 2010 05:15:58 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:121225 Archived-At: The font locking in js.el has confused me a lot when it comes to JS objects (or "dictionaries"). var dict = { variable: 1, callable: function () { } }; In this snippet "variable" gets the "default" face, whereas "callable" gets "font-lock-function-name-face". To be consistent I'd like it if one of the following changes are made: 1. "variable" gets "font-lock-variable-name-face" or some other non-default face. 2. Both "variable" and "callable" gets a new JS-specific face which give them both the same look. (My personal preference.) I'd supply a patch if my elisp-fu was better. Any thoughts on this? -- Deniz Dogan