From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#18175: files.el: use mapc in (mapcar 'switch-to-buffer ...) Date: Sun, 3 Aug 2014 11:43:48 -0700 (PDT) Message-ID: <7ac7622e-acbc-43ee-a58d-d1d97d3e8f16@default> References: <87r40yftes.fsf@violet.siamics.net> <3d8bb179-4e59-4d81-9ee1-54ff0da430b0@default> <87mwbmeyva.fsf@violet.siamics.net> <77fd6f4e-8cfd-49d1-884e-c61ce7a075a3@default> <87ha1tfn25.fsf@violet.siamics.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1407091535 21686 80.91.229.3 (3 Aug 2014 18:45:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 3 Aug 2014 18:45:35 +0000 (UTC) To: Ivan Shmakov , 18175@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 03 20:45:28 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XE0md-0000KC-NA for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Aug 2014 20:45:27 +0200 Original-Received: from localhost ([::1]:48855 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XE0md-0001WB-7U for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Aug 2014 14:45:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XE0mO-0001UL-IR for bug-gnu-emacs@gnu.org; Sun, 03 Aug 2014 14:45:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XE0mF-0003EL-QS for bug-gnu-emacs@gnu.org; Sun, 03 Aug 2014 14:45:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49257) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XE0mF-0003ED-NN for bug-gnu-emacs@gnu.org; Sun, 03 Aug 2014 14:45:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XE0mE-0004WA-P3 for bug-gnu-emacs@gnu.org; Sun, 03 Aug 2014 14:45:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Aug 2014 18:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18175 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18175-submit@debbugs.gnu.org id=B18175.140709144317275 (code B ref 18175); Sun, 03 Aug 2014 18:45:02 +0000 Original-Received: (at 18175) by debbugs.gnu.org; 3 Aug 2014 18:44:03 +0000 Original-Received: from localhost ([127.0.0.1]:56200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XE0lG-0004UY-Cf for submit@debbugs.gnu.org; Sun, 03 Aug 2014 14:44:02 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:18398) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XE0lC-0004Tv-7V for 18175@debbugs.gnu.org; Sun, 03 Aug 2014 14:43:58 -0400 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s73IhnR1009709 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 3 Aug 2014 18:43:49 GMT Original-Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet22.oracle.com (8.14.5+Sun/8.14.5) with ESMTP id s73IhlLi020300 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 3 Aug 2014 18:43:48 GMT Original-Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s73IhldJ022068; Sun, 3 Aug 2014 18:43:47 GMT In-Reply-To: <87ha1tfn25.fsf@violet.siamics.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6691.5000 (x86)] X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92084 Archived-At: > The docstring for the latter reads: > =E2=80=A6 If BUFFER-OR-NAME is a buffer, return it as given. > And I see no reason for a buffer /name/ to ever appear in the > lists returned from find-file-noselect. Yes, of course not. It needs to return a list of buffers. That's why I wrote that we need to "make sure that the list of buffers returned is the same in all cases as what is returned today." ^^^^^^^ > > I'm guessing that that can make a difference only if the intended > > buffer cannot be switched to (an error is raised). And in that case > > I'm guessing that the error raised would be handled correctly by > > `find-file*'. (I have not checked.) >=20 > =09As there=E2=80=99re no condition-case forms around switch-to-buffer > =09calls in find-file et al. =E2=80=93 no such error will be handled in a= ny > =09special way, and will just be signalled to the user as usual. That all I meant by handled (treated) by `find-file*', not that there is a `condition-case' with a handler. The point is that the behavior should remain the same; that's all. If it does, fine. > > You might also want to check to be sure that the effect on what > > `buffer-list' returns (after the calls to `switch-buffer*') remains > > the same. >=20 > =09AIUI, the buffer-list result depends solely on the order of > =09calls to switch-to-buffer, which is /not/ changed in any way. >=20 > > The calls to `switch-to-buffer*' here do not use non-nil NORECORD, so > > that at least can be ignored. But maybe take a look, to make sure. > > Some commands and other functions depend on the buffer order in > > `buffer-list', so this too should not be altered by your proposed > > change. Thanks for looking at and testing these things.