From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#45072: 28.0.50; Emacs switches other buffer back uncontrollably, if other window's buffer is changed by user during minibuffer editing Date: Wed, 9 Dec 2020 10:33:26 +0100 Message-ID: <7a7c3ef0-619d-cd76-a4e4-040009e33d75@gmx.at> References: <86eek3hvu5.fsf@protected.rcdrun.com> <87eek1fvgf.fsf@gnus.org> <83eek18ref.fsf@gnu.org> <835z5d8lhc.fsf@gnu.org> <87lfe8jsok.fsf@gnus.org> <83h7ow70ty.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------EE7172677FC90A372510258B" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16440"; mail-complaints-to="usenet@ciao.gmane.io" Cc: bugs@gnu.support, 45072@debbugs.gnu.org To: Eli Zaretskii , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 09 10:36:48 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmvtv-0004AY-9j for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Dec 2020 10:36:47 +0100 Original-Received: from localhost ([::1]:46734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmvtt-0000PZ-02 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Dec 2020 04:36:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmvsE-0000HB-40 for bug-gnu-emacs@gnu.org; Wed, 09 Dec 2020 04:35:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49496) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kmvsD-0002Qv-Qc for bug-gnu-emacs@gnu.org; Wed, 09 Dec 2020 04:35:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kmvsD-0003BT-O2 for bug-gnu-emacs@gnu.org; Wed, 09 Dec 2020 04:35:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Dec 2020 09:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45072 X-GNU-PR-Package: emacs Original-Received: via spool by 45072-submit@debbugs.gnu.org id=B45072.160750644912114 (code B ref 45072); Wed, 09 Dec 2020 09:35:01 +0000 Original-Received: (at 45072) by debbugs.gnu.org; 9 Dec 2020 09:34:09 +0000 Original-Received: from localhost ([127.0.0.1]:32792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmvrM-00039J-SB for submit@debbugs.gnu.org; Wed, 09 Dec 2020 04:34:09 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:46967) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kmvrK-00038m-HW for 45072@debbugs.gnu.org; Wed, 09 Dec 2020 04:34:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1607506408; bh=tK26AXfTtFwFNC+XtExGYY/OAAaCdYTnyKs5ynR6QzY=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=XjC/Ktz1Mabv9E25DZNcZDYYL5ps1/9hnvqoov2S8cLbnpwOoV94Z+rvRfbdi6S9n qmMPvK1mfmd0RhZB6wGd5P7ndc4DsVWboqxPgbv+2nx7xiobCnUa2hdln0h41znUQS csduEc6g1p94oVGDkOOgzkFZbq+ztiA+EktjuO5c= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([212.95.5.125]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M6UZv-1kkyqP2Wi1-006w1P; Wed, 09 Dec 2020 10:33:28 +0100 In-Reply-To: <83h7ow70ty.fsf@gnu.org> Content-Language: en-US X-Provags-ID: V03:K1:rK0wQdE/OZP8SzJAj+bS0UBT01lIx92qOh0+Emwyqm40Z6GJwfJ ltew1Oh/FupP5Ik38JId87K9q8slv/nVN5ebgbSg8ICCoeMtFfyO+OQC6dfw0MJTxy12vWZ hTMT9U0HFfAdDHh6Vp0R4RlCZljYAW8r1TrYNfy+F3oqr37IFe46X3p9Vsm0Gq6mTNYUOv9 Lhk/Jbau4ANqCvnfYwGPQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:mpJIWqUGtpc=:uFyNi5UdFMK6T4ZmyBsN1I E2/f0LWjzcJffOG1hQW7Uz7YKGQM4RQPXBVfuwL5Jt1zy9QVtsc9G+faUDvg65GAQAg7I7gO8 TVZ8qVp7mdiBqLnWFa4lQoVBC8ELY635Uu5CAIiXWONtLgfwQqNzcoNKSqMsnjaDxuyfoGIKa Hm4+BgyQLxqxjf3DuzYyt/5cX0LAT1XhqutQl1u/MtxbBISITG6PIl+puf9JDr5m0G01WhuML q4HLKI+7OXe4l3P7pFbNs29QPclIW6R1D4FWWH0+LwdZp2F1aw6N19NCJZWfnQDmcYdxyNO6g 29LWKWYFozC5jc9WDSG7zAr8L9UJpEsbLAcCP9JS3iDkOSYRHVpa+2YTHYQJpxZ72kKDm5qyd y/DSs+tQJNn0BfLm3NebLRs/MMKOskhxgZjb/wOngbuKhW//iiKX0vq8twFMhB4p1vO7/Sqfq tIR37PJBElXZVXfpY/J1CUoWSa1QSm3JJ+cTG9mmCjP5DAYjY+jki1tAaEewpXC80nOVJeHA6 9X3jL7Neq3WEeH/oJh7ahJLTeh+3+fAAXBYXbk1wA33B3FqYs7gc9vqBwqUC4mWHoqqMEUp7/ vn+zpOYDyEbAhCKGUvmXy9KZJ0SqpjS9S869JQ45AWpTiFHu0duZ82/3dztzsCrB3l4EazJ1v lDPKMJZ0+KIP8l2coJuCMKr1Zp6w5Ooxgk8htoGlxJITHZXUuk1RHLyIEBZqZE0SaYWQbj0JZ dIjXn+hm/nFrjrWDcY7eQh7ptgvD7f5LtYBrZLbBLIXQVT+SjvJ4sAXrV6ZsQUMh6V/7Sg6Q X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195480 Archived-At: This is a multi-part message in MIME format. --------------EE7172677FC90A372510258B Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit > Yes. But maybe read-from-minibuffer-restore-windows would be even > better. And `read-minibuffer-restore-windows' would be even shorter. Attached. martin --------------EE7172677FC90A372510258B Content-Type: text/x-patch; name="read-minibuffer-restore-windows.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="read-minibuffer-restore-windows.diff" =2D-- a/doc/lispref/minibuf.texi +++ b/doc/lispref/minibuf.texi @@ -458,6 +458,19 @@ Text from Minibuffer list is used in the prompt. @end defun +@defvar read-minibuffer-restore-windows +If this option is non-@code{nil} (the default), getting input from the +minibuffer will restore, on exit, the window configurations of the frame +where the minibuffer was entered from and, if it is different, the frame +that owns the minibuffer window. This means that if, for example, a +user splits a window while getting input from the minibuffer on the same +frame, that split will be undone when exiting the minibuffer. + +If this option is @code{nil}, no such restorations are done. Hence, the +window split mentioned above will persist after exiting the minibuffer. +@end defvar + + @node Object from Minibuffer @section Reading Lisp Objects with the Minibuffer @cindex minibuffer input, reading lisp objects =2D-- a/src/minibuf.c +++ b/src/minibuf.c @@ -500,19 +500,21 @@ read_minibuf (Lisp_Object map, Lisp_Object initial, = Lisp_Object prompt, record_unwind_protect_void (choose_minibuf_frame); - record_unwind_protect (restore_window_configuration, - Fcons (Qt, Fcurrent_window_configuration (Qnil))= ); + if (read_minibuffer_restore_windows) + record_unwind_protect (restore_window_configuration, + Fcons (Qt, Fcurrent_window_configuration (Qnil))); /* If the minibuffer window is on a different frame, save that frame's configuration too. */ mini_frame =3D WINDOW_FRAME (XWINDOW (minibuf_window)); - if (!EQ (mini_frame, selected_frame)) + + if (read_minibuffer_restore_windows && !EQ (mini_frame, selected_frame)= ) record_unwind_protect (restore_window_configuration, Fcons (/* Arrange for the frame later to be - switched back to the calling - frame. */ - Qnil, - Fcurrent_window_configuration (mini_fra= me))); + switched back to the calling + frame. */ + Qnil, + Fcurrent_window_configuration (mini_frame))); /* If the minibuffer is on an iconified or invisible frame, make it visible now. */ @@ -2186,6 +2188,15 @@ syms_of_minibuf (void) uses to hide passwords. */); Vread_hide_char =3D Qnil; + DEFVAR_BOOL ("read-minibuffer-restore-windows", read_minibuffer_restore= _windows, + doc: /* Non-nil means restore window configurations on exit from = minibuffer. +If this is non-nil (the default), reading input with the minibuffer will +restore, on exit, the window configurations of the frame where the +minibuffer was entered from and, if it is different, the frame that owns +the associated minibuffer window. If this is nil, no such restorations +are done. */); + read_minibuffer_restore_windows =3D true; + defsubr (&Sactive_minibuffer_window); defsubr (&Sset_minibuffer_window); defsubr (&Sread_from_minibuffer); --------------EE7172677FC90A372510258B--