From: Paul Eggert <eggert@cs.ucla.edu>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: emacs-devel@gnu.org
Subject: Re: Scan of regexps in emacs
Date: Mon, 11 Mar 2019 15:49:53 -0700 [thread overview]
Message-ID: <7a5591b6-e0a0-f465-719e-e453de1aef59@cs.ucla.edu> (raw)
In-Reply-To: <279B4953-57A1-4065-BF44-CF5B6E0835ED@acm.org>
On 3/11/19 1:51 AM, Mattias Engdegård wrote:
> - (if (looking-at iso2022-gb-designation)
> + (if (looking-at "\e\\$A")
>
> What about (regexp-quote iso2022-gb-designation) instead, possibly hoisted?
> (Of course the reader then wonders why iso2022-ascii-designation isn't quoted. Oh dear.)
I went through exactly the same thought processes. As variables like
iso2022-gb-designation are not really intended to be changed, I figured
it was OK to simply expand it inline by hand.
next prev parent reply other threads:[~2019-03-11 22:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-09 13:26 Scan of regexps in emacs Mattias Engdegård
2019-03-09 14:56 ` Alan Mackenzie
2019-03-09 15:09 ` Alan Mackenzie
2019-03-10 11:19 ` Mattias Engdegård
2019-03-09 17:06 ` Paul Eggert
2019-03-09 17:46 ` Alan Mackenzie
2019-03-11 2:45 ` Paul Eggert
2019-03-11 2:56 ` Clément Pit-Claudel
2019-03-11 3:37 ` Paul Eggert
2019-03-11 8:39 ` Mattias Engdegård
2019-03-11 8:51 ` Mattias Engdegård
2019-03-11 22:49 ` Paul Eggert [this message]
2019-03-12 10:21 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a5591b6-e0a0-f465-719e-e453de1aef59@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.