From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#67452: 30.0.50; [PATCH] Make split-root-window functions handle argument Date: Mon, 27 Nov 2023 10:20:36 +0100 Message-ID: <7a547440-ddc7-cdf6-2394-e006964285c1@gmx.at> References: <831qccbwxs.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36224"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67452@debbugs.gnu.org, hugo@heagren.com To: Eli Zaretskii , Cy Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 27 10:24:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r7Xqo-0009Cd-MS for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Nov 2023 10:24:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r7XqZ-0006b6-2R; Mon, 27 Nov 2023 04:24:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r7XoS-00060J-Pf for bug-gnu-emacs@gnu.org; Mon, 27 Nov 2023 04:22:00 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r7XoR-0005Re-F6 for bug-gnu-emacs@gnu.org; Mon, 27 Nov 2023 04:21:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r7XoX-0006pU-KD for bug-gnu-emacs@gnu.org; Mon, 27 Nov 2023 04:22:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Nov 2023 09:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67452-submit@debbugs.gnu.org id=B67452.170107689526219 (code B ref 67452); Mon, 27 Nov 2023 09:22:01 +0000 Original-Received: (at 67452) by debbugs.gnu.org; 27 Nov 2023 09:21:35 +0000 Original-Received: from localhost ([127.0.0.1]:43270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7Xo7-0006oo-HW for submit@debbugs.gnu.org; Mon, 27 Nov 2023 04:21:35 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:40473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7Xo4-0006oa-PZ for 67452@debbugs.gnu.org; Mon, 27 Nov 2023 04:21:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1701076838; x=1701681638; i=rudalics@gmx.at; bh=1V4Qz3j7xnjnK6iD1h0/19woAHMamssoHaYbU2l1pO4=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=fZCX2nqlYtRzHS4t8HmaPIewcBHSTKldNICyWpbZaarCana5ESam7yiczlYW7Qvy 4F/wzg3URBdqcvoXJ3f/2Hg2KvKYzqf51XDaE+L0riOgBI2kcvUigaB2XRT1hZQLv I5M/drZ93JG0RjJfP4XvifyiReV9yhpe1RcrAXM+IjiHeHf2TRYFO/7797RShHFxP aBqufzs0rakx+4zOGzzuMgJqrI6DjFzedr7Yp2t6s2an3Y/vhloteWhKXIs8cVcTq heT/K4YqwczgK09V5pTeTDHN12Yf6vpWWA2wuHz/eQg2nvGMWMZs9SrLvAOMUzQYA nXqfND5f03XHzgkSjA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from [192.168.31.113] ([213.142.96.139]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MbAci-1rj4TG1dWq-00beDs; Mon, 27 Nov 2023 10:20:38 +0100 Content-Language: en-US In-Reply-To: <831qccbwxs.fsf@gnu.org> X-Provags-ID: V03:K1:03w8cbhexE05LnI1S7EnhkwAUb+yi6fDOpLuJIGBTvRaSqQo9nH AnMRirc+OXXnzppdovFeObNTP9h6dzffS/OiavijB9/ewWxsZ+xQpY/wsK4HfPq96OYfMpD z4zKWMJnX51PyAzP6F4F+0YaDWLVx2oYHnTMEuqP0OS1htuoZS4l0mfpf6STJ2pGXcfgNDD PPX0Trfd/7Y7rWRCIg1+w== UI-OutboundReport: notjunk:1;M01:P0:bYdNWJPqius=;CmveuHT70LqJNQXv44BQR2DOHEY T9JEDdUafYhRBUZ4dpTC43dP2ml418Bvw+tf7z6z4jSTbJUkDhDrsm2x6qAxsuT8cMUuJm62m nlPnqUPetTepYSEIKawvmnaGfqNDEsPcNP0DHTJmSq37SDbguvkEZ6RwElFc2vikE0vrKYiRt iQmi+iJ4f7lbIWaggAHAwRRPlNWyLNJtlorb9eTQRfp094adn61Ib89IzAHv7Q1bLus8XrkL7 GuEMSklXNlB6715PfAPm0fFKRW2VfEPPZdeXJbDgd7a3mAup2I+NI+D33r7vmA8o9cmORF5jd GUHvXG3ff/PlFTk9p/5Ucr9cM+v8ZuAY3HQ5G+gfPjUpBJsxAJma+8k41S48URQkNWM66zWsp 76v90O13Ob2gLMFE5wXKldOLdM/jngFqtHp3phaf9V838bxIZ5lmXpCX+y3+e0z5DEnFnhrOu NIDd7Fi3pNUCDVG23ij9inDl/TH3NomYVHbg7AnEX91jv90D4xjlbBia4QCv4CvygefX7b9kE ICpb3zyKLbmixavA6/w5JD6rhXp3ePoZ5gngHk4AVAwh8K+o7p5+3CKClSALHUOEuaOC77etu z0B1xxwJoqK2QyhQJQeNKypPLa1oZ2vOaPtSDCTvIfVaVwUVvdxjW36w+7etRREKSXJIlQVKu 7xuARJsj/AxX70p2hH2ijumzoQz1/nZMIj1fUBh3roA8Z7dUKFSyT22xrpwCkhbFOzQhdftNs tb99MLZ4Id5kzhKWyDOsN8z/Fp+yL4pkYUmJb0MZYTKKGMiVRiH/90p63u8aKHDd9kE/O25+ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275111 Archived-At: > I guess we should do this for consistency with other split-window-* > commands? Martin, any reasons the split-root-window-* commands didn't > follow the example of the corresponding split-window-* commands? No idea. Maybe Hugo Heagren can tell. > In any case, to make the split-root-window-* commands support C-u we > just need to change the interactive spec from "P" to "p", there's no > need for anything more complex. I think so. Here 'split-window-below' and 'split-window-right' use (let* ((size (and size (prefix-numeric-value size))) maybe to "just work" when being passed an invalid SIZE argument but I don't remember the details. martin