Re: Don't complain about changed file when it hasn't changed

["Clément Pit--Claudel" <clement.pit@gmail.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 521 bytes --]

On 2016-08-30 11:01, Stefan Monnier wrote:
>> Also, why not just introduce a function buffer-min, instead of the
>>  (save-restriction) + (widen) dance?
> 
> We could, yes.
> 
> Note that it wouldn't help us in the present case, since we will look
> (via compare-buffer-substring) at the whole buffer's text, so we need to
> widen anyway.

I see, thanks! I didn't realize that these functions needed widening. Its documentation doesn't seem to mention it, nor its docstring. What about the attached patch?



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.1.2: 0001-Mention-that-compare-buffer-substrings-can-throw-arg.patch --]
[-- Type: text/x-diff; name="0001-Mention-that-compare-buffer-substrings-can-throw-arg.patch", Size: 1500 bytes --]

From d64d57cdee65775345fcd1511d2e1e9ac4539a42 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cl=C3=A9ment=20Pit--Claudel?= <clement.pitclaudel@live.com>
Date: Tue, 30 Aug 2016 11:20:10 -0400
Subject: [PATCH] ; Mention that compare-buffer-substrings can throw
 args-out-of-range

* doc/lispref/text.texi: Mention args-out-of-range.
---
 doc/lispref/text.texi | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/doc/lispref/text.texi b/doc/lispref/text.texi
index 213eec9..9f2ca11 100644
--- a/doc/lispref/text.texi
+++ b/doc/lispref/text.texi
@@ -340,9 +340,11 @@ Comparing Text
 This function lets you compare two substrings of the same buffer or two
 different buffers.  The first three arguments specify one substring,
 giving a buffer (or a buffer name) and two positions within the
-buffer.  The last three arguments specify the other substring in the
-same way.  You can use @code{nil} for @var{buffer1}, @var{buffer2}, or
-both to stand for the current buffer.
+buffer.  If these positions are not in the accessible portion of the
+buffer, @code{compare-buffer-substrings} signals an
+@code{args-out-of-range} error.  The last three arguments specify the
+other substring in the same way.  You can use @code{nil} for
+@var{buffer1}, @var{buffer2}, or both to stand for the current buffer.
 
 The value is negative if the first substring is less, positive if the
 first is greater, and zero if they are equal.  The absolute value of
-- 
2.7.4


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]