Re: /srv/bzr/emacs/trunk r106174: * lisp/progmodes/octave-inf.el (inferior-octave-mode-map): Fix C-c C-h binding.

Re: /srv/bzr/emacs/trunk r106174: * lisp/progmodes/octave-inf.el (inferior-octave-mode-map): Fix C-c C-h binding.

[Johan Bockgård]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> -    (define-key map "\C-c\C-h" 'octave-help)
> +    (define-key map "\C-c\C-h" 'info-lookup-symbol)

I think the C-c C-h binding should be removed instead.

    * Don't bind `C-h' following any prefix character (including `C-c').
      If you don't bind `C-h', it is automatically available as a help
      character for listing the subcommands of the prefix character.

    -- (info "(elisp) Key Binding Conventions")


(info-lookup-symbol already has a global binding.)

RE: /srv/bzr/emacs/trunk r106174: * lisp/progmodes/octave-inf.el(inferior-octave-mode-map): Fix C-c C-h binding.

[Drew Adams]

> I think the C-c C-h binding should be removed instead.

1+

Re: /srv/bzr/emacs/trunk r106174: * lisp/progmodes/octave-inf.el (inferior-octave-mode-map): Fix C-c C-h binding.

[Stefan Monnier]

>> -    (define-key map "\C-c\C-h" 'octave-help)
>> +    (define-key map "\C-c\C-h" 'info-lookup-symbol)

> I think the C-c C-h binding should be removed instead.

>     * Don't bind `C-h' following any prefix character (including `C-c').
>       If you don't bind `C-h', it is automatically available as a help
>       character for listing the subcommands of the prefix character.

You're right.  But it's been that way "for ever", so there's no hurry to
fix it.  Let's keep it for Emacs-24.2.


        Stefan