From: Andrii Kolomoiets <andreyk.mad@gmail.com>
To: Alan Third <alan@idiocy.org>
Cc: 40200@debbugs.gnu.org, 28872@debbugs.gnu.org, aaronjensen@gmail.com
Subject: bug#28872: [PATCH v2] Fix NS frame resizing issues (bug#40200, bug#28872)
Date: Fri, 27 Mar 2020 11:45:50 +0200 [thread overview]
Message-ID: <7F9C5AFC-02F1-490B-9DA0-6BC7C27A50E5@gmail.com> (raw)
In-Reply-To: <20200326212125.GA66331@breton.holly.idiocy.org>
[-- Attachment #1: Type: text/plain, Size: 601 bytes --]
On 26 Mar 2020, at 23:21, Alan Third <alan@idiocy.org> wrote:
>
> Hopefully this works better.
>
It is!
But can the following line be removed?
> + ns_clear_frame (emacsframe);
This removal resolves following issues for me:
1. Frames have white background color on creation. This flashing is noticeable while using dark background for default face.
2. I'm experimenting with enabling macos native tabs by replacing NSWindowTabbingModeDisallowed with NSWindowTabbingModePreferred in nsterm.m. Crash occurs on tabbed frame deletion (s-n s-w). Backtrace is attached.
Thanks!
[-- Attachment #2: emacs-crash-tab-close.txt --]
[-- Type: text/plain, Size: 5618 bytes --]
Exception Type: EXC_BAD_ACCESS (SIGABRT)
Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000020
Exception Note: EXC_CORPSE_NOTIFY
VM Regions Near 0x20:
-->
__TEXT 000000010aac2000-000000010ad09000 [ 2332K] r-x/r-x SM=COW /Users/USER/*/Emacs.app/Contents/MacOS/Emacs
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0 libsystem_kernel.dylib 0x00007fff6d2097fa __pthread_kill + 10
1 libsystem_pthread.dylib 0x00007fff6d2c6bc1 pthread_kill + 432
2 libsystem_c.dylib 0x00007fff6d1203a2 raise + 26
3 org.gnu.Emacs 0x000000010acc87a9 terminate_due_to_signal + 153 (emacs.c:404)
4 org.gnu.Emacs 0x000000010acc90eb emacs_abort + 15
5 org.gnu.Emacs 0x000000010ac90f60 ns_term_shutdown + 80 (lisp.h:1586)
6 org.gnu.Emacs 0x000000010ab808e4 shut_down_emacs + 340 (emacs.c:2462)
7 org.gnu.Emacs 0x000000010acc8776 terminate_due_to_signal + 102 (emacs.c:385)
8 org.gnu.Emacs 0x000000010aba10be handle_fatal_signal + 14
9 org.gnu.Emacs 0x000000010aba1141 deliver_thread_signal + 129
10 org.gnu.Emacs 0x000000010ab9faf9 deliver_fatal_thread_signal + 9
11 org.gnu.Emacs 0x000000010aba11f8 handle_sigsegv + 168
12 libsystem_platform.dylib 0x00007fff6d2bb42d _sigtramp + 29
13 ??? 000000000000000000 0 + 0
14 com.apple.CoreFoundation 0x00007fff35a1435f __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 12
15 com.apple.CoreFoundation 0x00007fff35a142f3 ___CFXRegistrationPost1_block_invoke + 63
16 com.apple.CoreFoundation 0x00007fff35a14268 _CFXRegistrationPost1 + 372
17 com.apple.CoreFoundation 0x00007fff35a13ebe ___CFXNotificationPost_block_invoke + 97
18 com.apple.CoreFoundation 0x00007fff359e37e2 -[_CFXNotificationRegistrar find:object:observer:enumerator:] + 1575
19 com.apple.CoreFoundation 0x00007fff359e2c82 _CFXNotificationPost + 1351
20 com.apple.AppKit 0x00007fff32c23719 -[NSView _postFrameChangeNotification] + 304
21 com.apple.AppKit 0x00007fff32c1c1a9 -[NSView setFrameSize:] + 2917
22 com.apple.AppKit 0x00007fff32c2dca2 -[NSView setFrame:] + 423
23 org.gnu.Emacs 0x000000010ac972ac -[EmacsView setFrame:] + 60 (nsterm.m:7329)
24 com.apple.AppKit 0x00007fff32c412ee -[NSView resizeWithOldSuperviewSize:] + 1193
25 com.apple.AppKit 0x00007fff32c40a13 -[NSView resizeSubviewsWithOldSize:] + 525
26 com.apple.AppKit 0x00007fff32c1bcf6 -[NSView setFrameSize:] + 1714
27 com.apple.AppKit 0x00007fff32c2dca2 -[NSView setFrame:] + 423
28 com.apple.AppKit 0x00007fff32c604f7 -[NSThemeFrame _relayoutAuxiliaryViewsOfType:] + 149
29 com.apple.AppKit 0x00007fff32c6044f -[NSThemeFrame relayoutAuxiliaryViewsOfType:] + 27
30 com.apple.AppKit 0x00007fff32e284fe -[NSTitlebarViewController removeChildViewControllerAtIndex:] + 430
31 com.apple.AppKit 0x00007fff3341b9f1 -[NSWindowStackController _removeTabBarAccessoryViewControllerForWindow:] + 212
32 com.apple.AppKit 0x00007fff3341cc7a -[NSWindowStackController removeWindow:] + 297
33 com.apple.AppKit 0x00007fff32e988af -[NSWindow(NSWindowTabbing) _doTabbedWindowCleanupForOrderOut] + 97
34 com.apple.AppKit 0x00007fff3347be55 -[NSWindow _finishClosingWindow] + 73
35 com.apple.AppKit 0x00007fff32f590cd -[NSWindow _close] + 352
36 org.gnu.Emacs 0x000000010ac8dd4a ns_free_frame_resources + 202 (nsterm.m:1705)
37 org.gnu.Emacs 0x000000010ac9fd5a ns_destroy_window + 106 (nsterm.m:1733)
38 org.gnu.Emacs 0x000000010aad1faa delete_frame + 1642 (frame.c:2137)
39 org.gnu.Emacs 0x000000010ac0d891 funcall_subr + 257
40 org.gnu.Emacs 0x000000010ac0ce7b Ffuncall + 843
41 org.gnu.Emacs 0x000000010ac06459 Ffuncall_interactively + 73 (callint.c:254)
42 org.gnu.Emacs 0x000000010ac0ce7b Ffuncall + 843
43 org.gnu.Emacs 0x000000010ac07948 Fcall_interactively + 5336
44 org.gnu.Emacs 0x000000010ac0d8b1 funcall_subr + 289
45 org.gnu.Emacs 0x000000010ac0ce7b Ffuncall + 843
46 org.gnu.Emacs 0x000000010ac50737 exec_byte_code + 1815 (bytecode.c:633)
47 org.gnu.Emacs 0x000000010ac0ce19 Ffuncall + 745
48 org.gnu.Emacs 0x000000010ac0d4ec call1 + 44
49 org.gnu.Emacs 0x000000010ab84ab9 command_loop_1 + 2009 (lisp.h:1272)
50 org.gnu.Emacs 0x000000010ac0b4c7 internal_condition_case + 263 (eval.c:1357)
51 org.gnu.Emacs 0x000000010ab94830 command_loop_2 + 48 (lisp.h:1272)
52 org.gnu.Emacs 0x000000010ac0acdb internal_catch + 267 (eval.c:1118)
53 org.gnu.Emacs 0x000000010acc8b75 command_loop.cold.1 + 69
54 org.gnu.Emacs 0x000000010ab838e3 command_loop + 131
55 org.gnu.Emacs 0x000000010ab83813 recursive_edit_1 + 115 (keyboard.c:714)
56 org.gnu.Emacs 0x000000010ab83a6b Frecursive_edit + 347 (keyboard.c:787)
57 org.gnu.Emacs 0x000000010ab82651 main + 7425 (emacs.c:2036)
58 libdyld.dylib 0x00007fff6d0c27fd start + 1
next prev parent reply other threads:[~2020-03-27 9:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 18:13 bug#40200: 28.0.50; NS: text drawing glitches in maximized frame with frame-inhibit-implied-resize Andrii Kolomoiets
2020-03-23 19:22 ` Eli Zaretskii
2020-03-23 19:47 ` Andrii Kolomoiets
2020-03-23 23:54 ` Alan Third
2020-03-25 22:28 ` bug#40200: [PATCH] Fix NS frame resizing issues (bug#40200, bug#28872) Alan Third
2020-03-26 17:35 ` bug#28872: " Andrii Kolomoiets
2020-03-26 21:21 ` bug#28872: [PATCH v2] " Alan Third
2020-03-27 9:45 ` Andrii Kolomoiets [this message]
2020-03-27 13:22 ` Andrii Kolomoiets
2020-03-28 1:56 ` Alan Third
2020-04-04 14:17 ` bug#40200: [PATCH v3] " Alan Third
2020-04-06 6:57 ` Andrii Kolomoiets
2020-04-06 18:44 ` bug#28872: [PATCH v4] " Alan Third
2020-04-07 8:14 ` bug#40200: " Andrii Kolomoiets
2020-04-16 18:24 ` bug#28872: " Alan Third
2020-04-18 1:52 ` bug#40200: " HaiJun Zhang
2020-04-18 12:07 ` Alan Third
2020-04-18 14:12 ` HaiJun Zhang
2020-04-18 15:26 ` Alan Third
2020-04-19 1:49 ` HaiJun Zhang
2020-05-03 16:26 ` Alan Third
2020-05-03 17:13 ` Filipp Gunbin
2020-05-03 18:41 ` Alan Third
2020-05-03 19:49 ` Filipp Gunbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7F9C5AFC-02F1-490B-9DA0-6BC7C27A50E5@gmail.com \
--to=andreyk.mad@gmail.com \
--cc=28872@debbugs.gnu.org \
--cc=40200@debbugs.gnu.org \
--cc=aaronjensen@gmail.com \
--cc=alan@idiocy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.